AppNexus debug auction via cookie #3314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkendall07
reviewed
Nov 21, 2018
modules/appnexusBidAdapter.js
Outdated
| @@ -450,6 +491,11 @@ function hasAppId(bid) { | |||
| return !!bid.params.app | |||
| } | |||
|
|
|||
| function getCookie(name) { | |||
There was a problem hiding this comment.
can you move this into utils ?
|
@jsnellbaker @mkendall07 added |
|
This pull request introduces 1 alert when merging 9615c67 into 7aef26e - view on LGTM.com new alerts:
Comment posted by LGTM.com |
jsnellbaker
approved these changes
Dec 4, 2018
jsnellbaker
added
the
needs 2nd review
loic-talon
pushed a commit
to onfocusio/Prebid.js
that referenced
this pull request
Dec 19, 2018
* updating appnexus debug auction to be cookie-only * adding getCookie to utils * remove LGTM alert on getCookie * fix failed tests
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* updating appnexus debug auction to be cookie-only * adding getCookie to utils * remove LGTM alert on getCookie * fix failed tests
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
* updating appnexus debug auction to be cookie-only * adding getCookie to utils * remove LGTM alert on getCookie * fix failed tests
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
The following feature enhancement adds in the ability for a publisher or developer to request an AppNexus debug auction in the response back from AppNexus alongside any bids.
This feature can be enabled by doing the following:
pbjs_debug=truequery string parameter.apn_prebid_debugcookie with a JSON string. For example:Sample Console Log: