Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove application json from bid request header #3346

Merged
merged 1 commit into from
Dec 13, 2018

Conversation

ankur-modi
Copy link
Contributor

@ankur-modi ankur-modi commented Dec 3, 2018

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@ankur-modi
Copy link
Contributor Author

@mkendall07 Can you please review this? Its little urgent.
Thanks

@ankur-modi
Copy link
Contributor Author

@jaiminpanchal27 Can we please get it reviewed?

@Nitinmittal84
Copy link

@mkendall07 Can you please help us with the review of this code.

Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkendall07 mkendall07 merged commit 5253d29 into prebid:master Dec 13, 2018
@jsnellbaker jsnellbaker removed their assignment Dec 18, 2018
@jsnellbaker jsnellbaker removed their request for review December 18, 2018 20:18
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants