Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rivr thin adapter #3351

Merged
merged 3 commits into from
Dec 19, 2018
Merged

Rivr thin adapter #3351

merged 3 commits into from
Dec 19, 2018

Conversation

AlessandroDG
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Delegates the events handling to an external component that Rivr will provide to publishers.

AlessandroDG and others added 2 commits December 5, 2018 11:30
Rivr thin adapter (#5)
970dc93 
* RVR-2049 - change impression event

* RVR-2049 - fix user id value returned on creation of the cookie

* RVR-2049 - remove blockedCategories and browser properties from Auction object

* RVR-2060 - rewrite rendering detection for impression and click events

* RVR-2060 - rewrite tests for rendering detection for impression and click events

* RVR-2049 - send ad unit code in click event

* RVR-2049 - adapt tests for click event

* RVR-2072 - split impression detection depending on the ad server - DFP/none

* RVR-2056 - set creativeId in Auction -> received bids

* RVR-2056 - set bid.clearPrice to cmp

* RVR-2087 - extract trackAuctionInit implementation to rivraddon

* RVR-2087 - extract implementation to rivraddon WIP

* RVR-2087 - extract implementation to rivraddon

* RVR-2087 - extract implementation to rivraddon

* RVR-2087 - Update package-lock
@AlessandroDG
RVR-2087 - Add addons check
1fb91d9
@jsnellbaker jsnellbaker self-requested a review December 10, 2018 15:05
jsnellbaker
jsnellbaker requested changes Dec 10, 2018
View reviewed changes
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AlessandroDG

I'm not sure why this didn't run automatically with the PR, but I ran the browserstack tests locally to see how these changes would affect other browsers.

I saw a consistent test failure in IE11. Below is a copy of the test failure:

RIVR Analytics adapter
    �[31m✗ �[39m�[31menableAnalytics - should call rivraddon enableAnalytics with the correct arguments�[39m
	expected undefined to equal 'ExpiringQueue'
	Error
	   at AssertionError (webpack:///node_modules/assertion-error/index.js:74 <- test/test_index.js:21117:7)
	   at Assertion.prototype.assert (webpack:///node_modules/chai/lib/chai/assertion.js:107 <- test/test_index.js:29152:7)
	   at assertEqual (webpack:///node_modules/chai/lib/chai/core/assertions.js:487 <- test/test_index.js:29669:7)
	   at ctx[name] (webpack:///node_modules/chai/lib/chai/utils/addMethod.js:41 <- test/test_index.js:28739:5)
	   at Anonymous function (webpack:///test/spec/modules/rivrAnalyticsAdapter_spec.js:128:4 <- test/test_index.js:129303:6)

Could you take a look and correct the issue?

@AlessandroDG
Copy link
Contributor Author

@jsnellbaker thank you for your feedback. I will run it locally too and apply the needed changes.

circleci/Browserstack configuration never really worked properly. In the previous PR I had a different issue. Your colleague tried to understand the cause but he couldn't because of the free plan you have with circleci.

Here you can find the conversation: #3202

Rivr Thin Adapter - part 2 (#6)
55e0ad2 
* RVR-2087 - Remove sendAuction call from ExpiringQueue

* RVR-2147 - Fix test failing on IE 11.0.0

* RVR-2087 - Remove ExpiringQueue
@AlessandroDG
Copy link
Contributor Author

@jsnellbaker browserstack tests ran now.

Anyway, I would really appreciate if you could help me figure out why the circleci build runs on our (Simplaex) instance rather then the Prebid one.

@jsnellbaker
Copy link
Collaborator

@AlessandroDG Thanks for making the updates.

In regards to the CircleCI job, I'm not 100% sure what to do here. From what we've seen, if the organization that houses the fork exists in CircleCI - it seems to default to run in that organization rather than in the target project. If you have any ideas here, please let us know.

@jsnellbaker jsnellbaker merged commit 49ea705 into prebid:master Dec 19, 2018
@AlessandroDG
Copy link
Contributor Author

@jsnellbaker Thanks for merging the PR.
And also for the input on CircleCI, I will investigate on our side and get back to you when I will find out something.

ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
Rivr thin adapter (prebid#3351)
a61c4f1 
* Rivr thin adapter (prebid#5)

* RVR-2049 - change impression event

* RVR-2049 - fix user id value returned on creation of the cookie

* RVR-2049 - remove blockedCategories and browser properties from Auction object

* RVR-2060 - rewrite rendering detection for impression and click events

* RVR-2060 - rewrite tests for rendering detection for impression and click events

* RVR-2049 - send ad unit code in click event

* RVR-2049 - adapt tests for click event

* RVR-2072 - split impression detection depending on the ad server - DFP/none

* RVR-2056 - set creativeId in Auction -> received bids

* RVR-2056 - set bid.clearPrice to cmp

* RVR-2087 - extract trackAuctionInit implementation to rivraddon

* RVR-2087 - extract implementation to rivraddon WIP

* RVR-2087 - extract implementation to rivraddon

* RVR-2087 - extract implementation to rivraddon

* RVR-2087 - Update package-lock

* RVR-2087 - Add addons check

* Rivr Thin Adapter - part 2 (prebid#6)

* RVR-2087 - Remove sendAuction call from ExpiringQueue

* RVR-2147 - Fix test failing on IE 11.0.0

* RVR-2087 - Remove ExpiringQueue
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
Rivr thin adapter (prebid#3351)
31b18a0 
* Rivr thin adapter (#5)

* RVR-2049 - change impression event

* RVR-2049 - fix user id value returned on creation of the cookie

* RVR-2049 - remove blockedCategories and browser properties from Auction object

* RVR-2060 - rewrite rendering detection for impression and click events

* RVR-2060 - rewrite tests for rendering detection for impression and click events

* RVR-2049 - send ad unit code in click event

* RVR-2049 - adapt tests for click event

* RVR-2072 - split impression detection depending on the ad server - DFP/none

* RVR-2056 - set creativeId in Auction -> received bids

* RVR-2056 - set bid.clearPrice to cmp

* RVR-2087 - extract trackAuctionInit implementation to rivraddon

* RVR-2087 - extract implementation to rivraddon WIP

* RVR-2087 - extract implementation to rivraddon

* RVR-2087 - extract implementation to rivraddon

* RVR-2087 - Update package-lock

* RVR-2087 - Add addons check

* Rivr Thin Adapter - part 2 (#6)

* RVR-2087 - Remove sendAuction call from ExpiringQueue

* RVR-2147 - Fix test failing on IE 11.0.0

* RVR-2087 - Remove ExpiringQueue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnellbaker jsnellbaker jsnellbaker approved these changes

Assignees

@jsnellbaker jsnellbaker

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlessandroDG @jsnellbaker