Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New bidder adapter for collectcent #3365

Merged
merged 7 commits into from
Dec 18, 2018
Merged

Conversation

devcollectcent
Copy link
Contributor

Type of change

  • New bidder adapter

Description of change

  • test parameters for validating bids
{
   	bidder: 'collectcent',
   	params: {
      		placementId: 0,
      		traffic: 'banner'
    	}
}

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

New bider adapter for collectcent
Description and integration example
Collectcent bidder adapter tests added
modules/collectcentBidAdapter.js Outdated Show resolved Hide resolved
modules/collectcentBidAdapter.js Outdated Show resolved Hide resolved
@mike-chowla
Copy link
Contributor

Your cookie sync URL is returning 404
https://publishers.motionspots.com/?c=o&m=cookie

Used bidderRequest.refererInfo.referer instead of window.location
@mkendall07
Copy link
Member

This pull request introduces 1 alert when merging 04c3ceb into 88156e7 - view on LGTM.com

new alerts:

  • 1 for Invocation of non-function

Comment posted by LGTM.com

@mkendall07
Copy link
Member

This pull request introduces 1 alert when merging 76ddb86 into 88156e7 - view on LGTM.com

new alerts:

  • 1 for Invocation of non-function

Comment posted by LGTM.com

Rename URL to URL_MULTI
@devcollectcent
Copy link
Contributor Author

Updated

@mike-chowla mike-chowla merged commit 14bf872 into prebid:master Dec 18, 2018
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
* Create collectcentBidAdapter.js

New bider adapter for collectcent

* Create collectcentBidAdapter.md

Description and integration example

* Create collectcentBidAdapter_spec.js

Collectcent bidder adapter tests added

* Update collectcentBidAdapter_spec.js

edit

* Update collectcentBidAdapter.js

Used bidderRequest.refererInfo.referer instead of window.location

* Update collectcentBidAdapter.js

* Update collectcentBidAdapter.js

Rename URL to URL_MULTI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants