-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new adapter for Appier bidder. #3370
Conversation
modules/appierBidAdapter.js
Outdated
* @return {Bid[]} An array of bids which were nested inside the server. | ||
*/ | ||
interpretResponse: function (serverResponse, serverRequest) { | ||
if (!serverResponse.body || !Array.isArray(serverResponse.body)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can optimize this conditional and it will behave the same:
if (!Array.isArray(serverResponse.body)) {
return []
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idettman I did the requested change and did git squash.
Thanks for the prompt review and the suggestions!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good except for the small fix mentioned on line #64, once this is fixed I'll approve
afb3f65
to
28f538b
Compare
@idettman BTW, once approved, when will this be released and available from the download menu on Prebid.js official website? I mean this: http://prebid.org/download.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Type of change
Description of change
Added a new bidder adapter for Appier.
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information