New adapter: Adhese

[mefjush]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

Adds a new adapter for integration with Adhese adserver (https://adhese.com/).

• test parameters for validating bids

{
  bidder: 'adhese',
  params: {
    account: 'demo',
    location: '_adhese_prebid_demo_',
    format: 'leaderboard',
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

• contact email of the adapter’s maintainer dev@adhese.eu
• official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

• A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/

Other information

[bretg]

docs PR prebid/prebid.github.io#1063

[jsnellbaker]

Hi @mefjush

Could you make some changes to the layout of the adapter file?

There are a number of what would normally be internal functions attached to the spec object (eg mergeTargets & bidToSlotName). We'd ask that you only include the expected/established functions to the spec object (see list here in the examples) and not expose these other functions.

If you have an explicit reason for structuring the file in this manner, please let us know.

[jsnellbaker]

@mefjush Thanks for making the updates to the various functions in the adapter file. When I was trying to test the updated adapter with the test params in the .md file, I wasn't getting any bids back from your server.

Below is a copy of the ad request's GET url:
https://ads-demo.adhese.com/json/sl_main_page_-middle/cigent;brussels/ag55/tlall?t=1546958978798

Can you take a look to see if something is amiss? Ideally we'd like to see a working test bid while reviewing new adapters to ensure the end-to-end is working fine. Thanks.

[mefjush]

Hi, the params in the .md file document only the syntax. The params I provided in the Pull Request header should work fine:
{ bidder: 'adhese', params: { account: 'demo', location: '_adhese_prebid_demo_', format: 'leaderboard', } }
Do you want me to update the .md file with the "working" params?

[jsnellbaker]

@mefjush Thanks for clarifying that; I tried the other params and they worked fine. Would you please update the md with the working copy. If someone needs to test your adapter later, it would ideal to have the params noted in the md rather than trying to dig up an old PR.

We should be good to merge once that's updated.

[mefjush]

@jsnellbaker sure makes sense, I also updated the params in the "docs" PR prebid/prebid.github.io#1063