Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Remaining Native Parameters from AppNexus Native response #3387

Merged
merged 3 commits into from
Jan 8, 2019
Merged

Adding Remaining Native Parameters from AppNexus Native response #3387

merged 3 commits into from
Jan 8, 2019

Conversation

aneuway2
Copy link
Contributor

@aneuway2 aneuway2 commented Dec 17, 2018 •
edited
Loading

Type of change

  • Feature
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

Description of change

Adds support for the following native parameters to prebid.js and the AppNexus adaptor:

  • displayUrl
  • address
  • downloads
  • likes
  • phone
  • price
  • salePrice

Example implementation

var adUnits = [{
  code: 'div-id',
  mediaTypes: {
	  native: {
                displayUrl: {
                    required: true
                },
                address: {
                    required: true
                },
                downloads: {
                    required: true
                },
                likes: {
                    required: true
                },
                phone: {
                    required: true
                },
                price: {
                    required: true
                },
                salePrice: {
                    required: true
                }
	  }
  },
  bids: [...]
}];

@aneuway2 aneuway2 mentioned this pull request Dec 17, 2018
Merged
@mike-chowla mike-chowla self-assigned this Dec 18, 2018
@stale
Copy link

stale bot commented Jan 1, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 1, 2019
@aneuway2
Copy link
Contributor Author

aneuway2 commented Jan 2, 2019

bump (as i'm sure we were all just on holiday and this is not stale)

@stale stale bot removed the stale label Jan 2, 2019
@mike-chowla mike-chowla self-requested a review January 2, 2019 23:25
mike-chowla
mike-chowla approved these changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I have some doubts about the wisdom of trying to send a VAST response through a targeting key, I'm approving

@mike-chowla mike-chowla added the needs 2nd review Core module updates require two approvals from the core team label Jan 2, 2019
@jsnellbaker jsnellbaker self-requested a review January 3, 2019 20:47
jsnellbaker
jsnellbaker requested changes Jan 3, 2019
View reviewed changes
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See below.

modules/appnexusBidAdapter.js Outdated Show resolved Hide resolved
mkendall07
mkendall07 approved these changes Jan 7, 2019
View reviewed changes
Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mkendall07
Copy link
Member

@mike-chowla fyi we dropped the VAST property.

@jsnellbaker jsnellbaker merged commit e9dea17 into prebid:master Jan 8, 2019
amuraco pushed a commit to amuraco/Prebid.js that referenced this pull request Jan 28, 2019
@aneuway2
Adding Remaining Native Parameters from AppNexus Native response (pre…
f5bb5ea 
…bid#3387)

* Adding remaining missing parameters from AppNexus Native response

* Removed native video, renamed sale and clickLabel to RTB spec names

* drop video from tests
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
@aneuway2
Adding Remaining Native Parameters from AppNexus Native response (pre…
543f449 
…bid#3387)

* Adding remaining missing parameters from AppNexus Native response

* Removed native video, renamed sale and clickLabel to RTB spec names

* drop video from tests
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
@aneuway2
Adding Remaining Native Parameters from AppNexus Native response (pre…
18d694e 
…bid#3387)

* Adding remaining missing parameters from AppNexus Native response

* Removed native video, renamed sale and clickLabel to RTB spec names

* drop video from tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnellbaker jsnellbaker jsnellbaker approved these changes

@mike-chowla mike-chowla mike-chowla approved these changes

@mkendall07 mkendall07 mkendall07 approved these changes

Assignees

@jsnellbaker jsnellbaker

Labels
needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aneuway2 @mkendall07 @mike-chowla @jsnellbaker