Support Multi-Format Ads - Banner & Video #3389
Conversation
|
This pull request fixes 1 alert when merging a703b3d into 14bf872 - view on LGTM.com fixed alerts:
Comment posted by LGTM.com |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
There was a problem hiding this comment.
When I was attempting to test these changes with the updated test params in the md file, I wasn't receiving anything from your server (saw a 204 No Content response).
Below is a copy of the request and it's newly formatted payload:
url: http://tag.1rx.io/rmp/72721/0/mvo?z=1r&hbv=1.37.0-pre,1.0.2
payload:
{"id":"1761f3bf7e4a8c","imp":[{"id":"div-gpt-ad-1460505748561-0","bidfloor":0,"secure":0,"banner":{"w":300,"h":250},"ext":{"bidder":{"placementId":"411806","zone":"1r","path":"mvo"}}}],"site":{"domain":"ap.localhost","page":"http://ap.localhost:9999/integrationExamples/gpt/hello_world.html?pbjs_debug=true","ref":"http://ap.localhost:9999/integrationExamples/gpt/hello_world.html?pbjs_debug=true"},"device":{"ua":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.80 Safari/537.36","devicetype":2,"ip":"","dnt":0},"user":{"ext":{"consent":""}},"at":1,"tmax":1000,"regs":{"ext":{"gdpr":true}}}
Could you please review and see if something is amiss?
|
@jsnellbaker The provided test placement got ended. |
|
I tried to use the new endpoint, however it doesn't seem to be working. I'm still getting a 204 response despite multiple attempts. Below is a copy of the payload/URL for reference: |
modules/rhythmoneBidAdapter.js
Outdated
| @@ -1,12 +1,24 @@ | |||
| 'use strict'; | |||
|
|
|||
| import * as utils from 'src/utils'; | |||
There was a problem hiding this comment.
Due to a recent merge (see #3435), we now require any imports for a core or modules file (like this adapter file) to use a relative path style.
Can you please update this line here?
There was a problem hiding this comment.
I have updated the recent merge mentioned. Please validate.
@jsnellbaker if you still see 204 No Content response, please let me know your location.
Just want to make sure ads are targeted to your location.
|
This pull request fixes 1 alert when merging dd1a71e into 92bfb29 - view on LGTM.com fixed alerts:
Comment posted by LGTM.com |
…hmoneBidAdapter.md file
|
This pull request fixes 1 alert when merging c74b7da into 92bfb29 - view on LGTM.com fixed alerts:
Comment posted by LGTM.com |
|
This pull request fixes 1 alert when merging 5d2ee53 into 92bfb29 - view on LGTM.com fixed alerts:
Comment posted by LGTM.com |
|
@RajeshRhythmone Thanks for making the import updates. In terms of the ad delivery, I'm located outside of Philadelphia. If you need any more specifics, let me know and we can chat through e-mail. |
|
@jsnellbaker Sure, chat through e-mail should work for me. Let me know your id, will ping you. Thanks |
|
Hi @RajeshRhythmone my email is jason.snellbaker@xandr.com |
|
@RajeshRhythmone Thanks for sending the customized test params. They worked fine for me. |
|
Thanks @jsnellbaker |
* Support Multi-Format Ads - Banner & Video * Updated gdpr default value to false, updated test placementId in rhythmoneBidAdapter.md file * Version updated
Type of change
Description of change
Support for Multi-Format Ads - Banner & Video
Updated ttl value for Banner & Video.
contact email of the adapter’s maintainer: support@rhythmone.com
official adapter submission
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide: