Fix #3265 - pbs cookie sync race condition #3393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
jsnellbaker
requested review from
mkendall07
and removed request for
jaiminpanchal27
mkendall07
requested changes
Jan 3, 2019
| /** | ||
| * Run a cookie sync for the given type, url, and bidder | ||
| * | ||
| * @param {string} type the type of sync, "image", "redirect", "iframe" | ||
| * @param {string} url the url to sync | ||
| * @param {string} bidder name of bidder doing sync for | ||
| */ | ||
| function doBidderSync(type, url, bidder) { | ||
| function doBidderSync(type, url, bidder, done) { |
There was a problem hiding this comment.
can you update the JSdoc params for done ?
| @@ -616,11 +620,15 @@ exports.insertHtmlIntoIframe = function(htmlCode) { | |||
| * @param {string} url URL to be requested | |||
| * @param {string} encodeUri boolean if URL should be encoded before inserted. Defaults to true | |||
| */ | |||
| exports.insertUserSyncIframe = function(url) { | |||
| exports.insertUserSyncIframe = function(url, done) { | |||
|
@mkendall07 Thanks for the feedback; I added the missing jsdoc comments. |
mkendall07
approved these changes
Jan 3, 2019
olafbuitelaar
pushed a commit
to olafbuitelaar/Prebid.js
that referenced
this pull request
Jan 3, 2019
* Fix prebid#3265 - pbs cookie sync race condition * add/update jsdoc comments
amuraco
pushed a commit
to amuraco/Prebid.js
that referenced
this pull request
Jan 28, 2019
* Fix prebid#3265 - pbs cookie sync race condition * add/update jsdoc comments
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* Fix prebid#3265 - pbs cookie sync race condition * add/update jsdoc comments
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
* Fix prebid#3265 - pbs cookie sync race condition * add/update jsdoc comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Fixes #3265