Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pbs adapter support bidder specifc options #3394

Conversation

idettman
Copy link
Contributor

@idettman idettman commented Dec 18, 2018

Type of change

  • Feature

PR for the docs addition:

PR#1075

Description of change

Feature allow pubs to insert an 'adapterOptions' parameter in s2sConfig that adds arguments to the resulting OpenRTB payload that goes to Prebid Server.

pbjs.setConfig({
  s2sConfig: {
    adapterOptions: {
      rubicon: {singleRequest: false}
    }
  }
});

// With this argument, the PBJS PBS adapter would insert the following ext object:
bidRequest: {
    ext: {
        rubicon: {
            singleRequest: false
        }
    }
}

// multiple bidders
pbjs.setConfig({
  s2sConfig: {
    adapterOptions: {
     rubicon: {singleRequest: false},
     appnexus: {key: "value"}
    }
  }
});

// With this argument, the PBJS PBS adapter would insert the following ext object
bidRequest: {
    ext: {
        rubicon: {
            singleRequest: false
        },
        appnexus: {
             key: "value"
        }
    }
}

@jsnellbaker
Copy link
Collaborator

@idettman Can you resolve the conflicts?

@idettman idettman requested a review from harpere December 20, 2018 08:52
@idettman idettman added needs 2nd review Core module updates require two approvals from the core team and removed needs update labels Dec 20, 2018
Copy link
Collaborator

@harpere harpere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code LGTM but I have a question about hard coding this default setting into the config.

modules/prebidServerBidAdapter/config.js Outdated Show resolved Hide resolved
@idettman idettman removed the needs 2nd review Core module updates require two approvals from the core team label Dec 20, 2018
test/spec/modules/prebidServerBidAdapter_spec.js Outdated Show resolved Hide resolved
test/spec/modules/prebidServerBidAdapter_spec.js Outdated Show resolved Hide resolved
@idettman
Copy link
Contributor Author

revisions implemented and ready for review

Copy link
Collaborator

@harpere harpere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker
Copy link
Collaborator

@idettman Is there a docs PR already created in regards to these changes? If not, can you please put one together?

@idettman
Copy link
Contributor Author

idettman commented Jan 2, 2019

Docs PR at: prebid/prebid.github.io#1075

@jsnellbaker jsnellbaker merged commit 9b47b1a into prebid:master Jan 2, 2019
olafbuitelaar pushed a commit to olafbuitelaar/Prebid.js that referenced this pull request Jan 3, 2019
* inprogress

* add support for s2sConfig bidderOptions

* merged missing updates from origin

* changed arrow function in spec mocha tests to standard functions

* fixed missing closing bracket and paren

* updated incorrect spec expected values for s2sConfig tests

* removed rubicon specific s2s configuration default value for sra

* deleted unnecessary test and revised a test description since the rubicon specific defaults were removed

* removed jsdoc for deprecated cookieSetUrl
amuraco pushed a commit to amuraco/Prebid.js that referenced this pull request Jan 28, 2019
* inprogress

* add support for s2sConfig bidderOptions

* merged missing updates from origin

* changed arrow function in spec mocha tests to standard functions

* fixed missing closing bracket and paren

* updated incorrect spec expected values for s2sConfig tests

* removed rubicon specific s2s configuration default value for sra

* deleted unnecessary test and revised a test description since the rubicon specific defaults were removed

* removed jsdoc for deprecated cookieSetUrl
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
* inprogress

* add support for s2sConfig bidderOptions

* merged missing updates from origin

* changed arrow function in spec mocha tests to standard functions

* fixed missing closing bracket and paren

* updated incorrect spec expected values for s2sConfig tests

* removed rubicon specific s2s configuration default value for sra

* deleted unnecessary test and revised a test description since the rubicon specific defaults were removed

* removed jsdoc for deprecated cookieSetUrl
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
* inprogress

* add support for s2sConfig bidderOptions

* merged missing updates from origin

* changed arrow function in spec mocha tests to standard functions

* fixed missing closing bracket and paren

* updated incorrect spec expected values for s2sConfig tests

* removed rubicon specific s2s configuration default value for sra

* deleted unnecessary test and revised a test description since the rubicon specific defaults were removed

* removed jsdoc for deprecated cookieSetUrl
@idettman idettman deleted the HB-2148_pbs_adapter_support_bidder_specifc_options branch March 18, 2019 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants