-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pbs adapter support bidder specifc options #3394
pbs adapter support bidder specifc options #3394
Conversation
@idettman Can you resolve the conflicts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code LGTM but I have a question about hard coding this default setting into the config.
…icon specific defaults were removed
revisions implemented and ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@idettman Is there a docs PR already created in regards to these changes? If not, can you please put one together? |
Docs PR at: prebid/prebid.github.io#1075 |
* inprogress * add support for s2sConfig bidderOptions * merged missing updates from origin * changed arrow function in spec mocha tests to standard functions * fixed missing closing bracket and paren * updated incorrect spec expected values for s2sConfig tests * removed rubicon specific s2s configuration default value for sra * deleted unnecessary test and revised a test description since the rubicon specific defaults were removed * removed jsdoc for deprecated cookieSetUrl
* inprogress * add support for s2sConfig bidderOptions * merged missing updates from origin * changed arrow function in spec mocha tests to standard functions * fixed missing closing bracket and paren * updated incorrect spec expected values for s2sConfig tests * removed rubicon specific s2s configuration default value for sra * deleted unnecessary test and revised a test description since the rubicon specific defaults were removed * removed jsdoc for deprecated cookieSetUrl
* inprogress * add support for s2sConfig bidderOptions * merged missing updates from origin * changed arrow function in spec mocha tests to standard functions * fixed missing closing bracket and paren * updated incorrect spec expected values for s2sConfig tests * removed rubicon specific s2s configuration default value for sra * deleted unnecessary test and revised a test description since the rubicon specific defaults were removed * removed jsdoc for deprecated cookieSetUrl
* inprogress * add support for s2sConfig bidderOptions * merged missing updates from origin * changed arrow function in spec mocha tests to standard functions * fixed missing closing bracket and paren * updated incorrect spec expected values for s2sConfig tests * removed rubicon specific s2s configuration default value for sra * deleted unnecessary test and revised a test description since the rubicon specific defaults were removed * removed jsdoc for deprecated cookieSetUrl
Type of change
PR for the docs addition:
PR#1075
Description of change
Feature allow pubs to insert an 'adapterOptions' parameter in s2sConfig that adds arguments to the resulting OpenRTB payload that goes to Prebid Server.