Support for Native in Pubmatic Adapter

[pm-shashank-jain]

Type of change

• Feature

Description of change

Support for native bid request in pubmatic bid adapter

• sample parameters for validating native bid requests

var adUnits = [
{
    code: 'test-div',    
    mediaTypes: {
       native: {
            image: {
                required: true,
                sizes: [150, 50]
            },
            title: {
                required: true,
                len: 80
            },
            sponsoredBy: {
                required: true
            },
            clickUrl: {
                required: true
            }
        }
    },
    bids: [{
      bidder: 'pubmatic',
      params: {
        publisherId: '156209',               // required
        adSlot: 'pubmatic_test2@1x1',       // required
      }
    }]
}];

• contact email of the adapter’s maintainer
• official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

• PR for docs at Support for Native in Pubmatic Adapter  prebid.github.io#1073

Other information

@pm-harshad-mane @mike-chowla

[jsnellbaker]

Hi @pm-shashank-jain

The changes in the files look fine. There are a few things to be reviewed however:

• code coverage > with these changes, the code coverage % for the adapter file dropped from 84.77% to 79.73%. While this is close to the usual preferred threshold (80%), would you be able to re-review the unit tests and see if there's something that can be put together to help close the gap?
• While attempting to test the native changes with the test params in the .md file, I wasn't getting a response from your server (received a 204 No Content). Further below is a copy of the request object that was executed - could you take a look to see if there's something incorrect?

Request's payload

{"id":"1546613828377","at":1,"cur":["USD"],"imp":[{"id":"2c932f813e502d","tagid":"pubmatic_test2","secure":0,"ext":{},"bidfloorcur":"USD","native":{"request":"{\"assets\":[{\"id\":2,\"required\":1,\"img\":{\"type\":3,\"w\":150,\"h\":50}},{\"id\":1,\"required\":1,\"title\":{\"len\":80}},{\"id\":4,\"required\":1,\"data\":{\"type\":1}}]}"}}],"site":{"page":"http://ap.localhost:9999/integrationExamples/gpt/demo_native.html?pbjs_debug=true","ref":"http://ap.localhost:9999/integrationExamples/gpt/demo_native.html?pbjs_debug=true","publisher":{"id":"156209"},"domain":"ap.localhost"},"device":{"ua":"Mozilla/5.0 (Linux; Android 6.0; Nexus 5 Build/MRA58N) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.80 Mobile Safari/537.36","js":1,"dnt":0,"h":475,"w":1814,"language":"en-US","geo":{}},"user":{"geo":{}},"ext":{"wrapper":{"wv":"prebid_prebid_1.37.0-pre","transactionId":"ed23078a-0994-4340-9e75-4dab515a58e8","wp":"pbjs"}}}

[pm-shashank-jain]

Hi @pm-shashank-jain

The changes in the files look fine. There are a few things to be reviewed however:

* code coverage > with these changes, the code coverage % for the adapter file dropped from 84.77% to 79.73%. While this is close to the usual preferred threshold (80%), would you be able to re-review the unit tests and see if there's something that can be put together to help close the gap?

* While attempting to test the native changes with the test params in the .md file, I wasn't getting a response from your server (received a 204 No Content).  Further below is a copy of the request object that was executed - could you take a look to see if there's something incorrect?

Request's payload

{"id":"1546613828377","at":1,"cur":["USD"],"imp":[{"id":"2c932f813e502d","tagid":"pubmatic_test2","secure":0,"ext":{},"bidfloorcur":"USD","native":{"request":"{\"assets\":[{\"id\":2,\"required\":1,\"img\":{\"type\":3,\"w\":150,\"h\":50}},{\"id\":1,\"required\":1,\"title\":{\"len\":80}},{\"id\":4,\"required\":1,\"data\":{\"type\":1}}]}"}}],"site":{"page":"http://ap.localhost:9999/integrationExamples/gpt/demo_native.html?pbjs_debug=true","ref":"http://ap.localhost:9999/integrationExamples/gpt/demo_native.html?pbjs_debug=true","publisher":{"id":"156209"},"domain":"ap.localhost"},"device":{"ua":"Mozilla/5.0 (Linux; Android 6.0; Nexus 5 Build/MRA58N) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.80 Mobile Safari/537.36","js":1,"dnt":0,"h":475,"w":1814,"language":"en-US","geo":{}},"user":{"geo":{}},"ext":{"wrapper":{"wv":"prebid_prebid_1.37.0-pre","transactionId":"ed23078a-0994-4340-9e75-4dab515a58e8","wp":"pbjs"}}}

Increased code coverage to 85%, updated pub id for which you will receive bids
@jsnellbaker can you please review it again

[jsnellbaker]

@pm-shashank-jain Thanks for making the updates; I confirmed the code coverage looks good now and the updated test params was returning a bid response.