-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User ID Module #3424
User ID Module #3424
Conversation
…d cookie browser support
…ow to handle both 'value' and 'storage' existing in config
…inition in function arguments
…bmodules and configs
…nt of refactoring/formatting cleanup
… add test for one storage type active with only one module configured to use that type
…ook due to necessary use of prebid global object affecting following tests
…ows watching the first element added to add the bid request hook
…red value does not exist
…invalid config storage type, revised commenting
…project/Prebid.js into add-user-id-module
…ror on cirlceci for the Safari Browsers
@pycnvr , @jsnellbaker , @snapwich - hoping to release this next week with 2.10. I believe Isaac's updated it with the inspection requests except for some features that I propose we hash out in a separate thread. |
Looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@idettman Should this be using |
User ID Module
Type of change
Description of change
This module adds a User ID module, which currently includes submodules for Unified ID and Pub Common ID.
Submodule Configuration
Each submodule can configure how it stores user id data to the the browser.
type: sets the browser storage API used to store the user data. The supported types are
html5
, orcookie
html5
useswindow.localStorage
cookie
usesdocument.cookies
expires: days to expire to locally stored values
name: the name of the key used to store user data
Example