Add support to pass custom key in Prebid cache request #3437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaiminpanchal27
added
LGTM
needs 2nd review
matthewlane
approved these changes
Jan 31, 2019
matthewlane
removed
the
needs 2nd review
jacekburys-quantcast
pushed a commit
to jacekburys-quantcast/Prebid.js
that referenced
this pull request
May 15, 2019
* add support to pass custom key in PBC request * update logic to allow individual custom keys per bid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Add support to pass a
keyparam inside the Prebid Cache request generated fromvideoCache.js. When the value is passed and the bid is successfully cached, the bid is cached using that key instead of the UUID value normally generated by Prebid Cache.The value for this
keyparam is ready from a new field in thebidobject (bid.customCacheKey) that is populated earlier in the auction workflow.Related PR prebid/prebid-cache#45
update
Based on initial testing after the above PR was merged and PBC was updated; an issue was discovered with the new functionality. A fix was identified and is being addressed via: prebid/prebid-cache#48