Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix orbidder pathing and test #3451

Merged
merged 1 commit into from
Jan 15, 2019
Merged

fix orbidder pathing and test #3451

merged 1 commit into from
Jan 15, 2019

Conversation

snapwich
Copy link
Collaborator

Type of change

  • Bugfix

Description of change

Fix include paths to be relative. Fix test to not rely on stubbing ajax module (which doesn't work quite correctly with sinon and es6).

Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will merge when CI finishes.

@mkendall07 mkendall07 merged commit 78f2d22 into master Jan 15, 2019
@mkendall07 mkendall07 deleted the orbidder-fix branch January 15, 2019 21:30
amuraco pushed a commit to amuraco/Prebid.js that referenced this pull request Jan 28, 2019
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
jacekburys-quantcast pushed a commit to jacekburys-quantcast/Prebid.js that referenced this pull request May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants