Tests: ensure 12:00:00 hour part on fake timestamp #3452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkendall07
approved these changes
Jan 16, 2019
|
Thanks, this was a quick fix to deal with the effect rather than the cause. The underlying code should probably be modified to use |
amuraco
pushed a commit
to amuraco/Prebid.js
that referenced
this pull request
Jan 28, 2019
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
jacekburys-quantcast
pushed a commit
to jacekburys-quantcast/Prebid.js
that referenced
this pull request
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Hello, the currency unit tests are currently setting a fake timestamp to
1047010195974, equivalent to2003-03-07T04:09:55Z. Tests that depend on this value fail on any machine with a TZ of UTC+12 to UTC-4, including the common timezone of UTC itself.The change in this PR winds the fake timestamp back to the equivalent of
2003-03-06T12:00:00Zso the tests will pass with any TZ from UTC+12 to UTC-11.