Frank fpd issue #3455
Merged
Frank fpd issue #3455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idettman
approved these changes
Jan 16, 2019
idettman
suggested changes
Jan 16, 2019
There was a problem hiding this comment.
Consider adding logic to wrap string or number in array.
if (Array.isArray(params.visitor[key])) {
slotData.visitor[key] = params.visitor[key]
} else if ((typeof params.visitor[key] === 'string' && params.visitor[key] !== '') || typeof params.visitor[key] === 'number') {
slotData.visitor[key] = [params.visitor[key]]
}
harpere
requested changes
Jan 25, 2019
There was a problem hiding this comment.
I like @idettman's suggestion about putting scalars in arrays.
let value = params.visitor[key];
if (Array.isArray(value)) {
slotData.visitor[key] = value;
} else if ((typeof value === 'string' && value !== '') || typeof value === 'number') {
slotData.visitor[key] = [value];
}
idettman
approved these changes
Jan 25, 2019
robertrmartinez
commented
Jan 25, 2019
| expect(slot.visitor).to.have.property('ucat').that.equals('new'); | ||
| expect(slot.visitor).to.have.property('lastsearch').that.equals('iphone'); | ||
| expect(slot.visitor).to.have.property('ucat').that.deep.equals(['new']); | ||
| expect(slot.visitor).to.have.property('lastsearch').that.deep.equals(['iphone']); |
There was a problem hiding this comment.
Now instead of sending a bad request it is sending the array wrapped data which will be accepted by Frank.
robertrmartinez
commented
Jan 25, 2019
|
|
||
| if (params.keywords && Array.isArray(params.keywords)) { | ||
| slotData.keywords = params.keywords; | ||
| } | ||
|
|
||
| if (params.visitor && typeof params.visitor === 'object') { | ||
| slotData.visitor = params.visitor; | ||
| } |
There was a problem hiding this comment.
combined both visitor and inventory into one block since they have same requirements and necessary checks.
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
* Changing to requestId in order to align with prebid cores mapping of bidId to responseId * Rubi Bid Adapter: Do not pass non-array FPD to Frank Video * Updating based on review + tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Noticed that we do not check the validity of visitor and inventory fpd values before forwarding through.
If each key in the inventory or visitor object is not an array of values, FRANK will 400.
This change verifies they are arrays before attaching them.