Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove old dependencies and solve some peer dependencies #3456

Merged
merged 3 commits into from
Jan 28, 2019
Merged

remove old dependencies and solve some peer dependencies #3456

merged 3 commits into from
Jan 28, 2019

Conversation

snapwich
Copy link
Collaborator

Type of change

  • Refactoring (no functional changes, no api changes)

Description of change

Removed unused dependencies, consolidated some dependencies, and solved some peer-dependency warnings (by downgrading ajv).

@snapwich snapwich force-pushed the clean-up-dependencies branch from 346e8b0 to ccaeead Compare January 24, 2019 16:59
@jaiminpanchal27
Copy link
Collaborator

LGTM.
Just one question, why do you remove gulp-coveralls. It is getting used here https://github.com/prebid/Prebid.js/blob/master/gulpfile.js#L270

@jaiminpanchal27 jaiminpanchal27 added LGTM needs 2nd review Core module updates require two approvals from the core team labels Jan 25, 2019
@snapwich
Copy link
Collaborator Author

@jaiminpanchal27 that's coveralls, not gulp-coveralls. it doesn't look like we use the later anywhere.

@jsnellbaker jsnellbaker self-requested a review January 28, 2019 15:25
jsnellbaker
jsnellbaker approved these changes Jan 28, 2019
View reviewed changes
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker merged commit af9ec3f into master Jan 28, 2019
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
@snapwich
remove old dependencies and solve some peer dependencies (prebid#3456)
9a1cfb8 
* remove old dependencies and solve some peer dependencies

* resolve package lock conflict

* add coveralls dependency
jacekburys-quantcast pushed a commit to jacekburys-quantcast/Prebid.js that referenced this pull request May 15, 2019
@snapwich @jacekburys-quantcast
remove old dependencies and solve some peer dependencies (prebid#3456)
6a043be 
* remove old dependencies and solve some peer dependencies

* resolve package lock conflict

* add coveralls dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnellbaker jsnellbaker jsnellbaker approved these changes

@jaiminpanchal27 jaiminpanchal27 jaiminpanchal27 approved these changes

Assignees
No one assigned
Labels
LGTM needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snapwich @jaiminpanchal27 @jsnellbaker