calling for currency file even when default rates are specified #3470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 22, 2019 10:40
…hen default rates are set
idettman
approved these changes
Jan 22, 2019
idettman
added
the
needs 2nd review
mkendall07
reviewed
Jan 22, 2019
| @@ -11,6 +11,7 @@ const CURRENCY_RATE_PRECISION = 4; | |||
| var bidResponseQueue = []; | |||
| var conversionCache = {}; | |||
| var currencyRatesLoaded = false; | |||
| var needToCallForCurrencyFile = true; | |||
There was a problem hiding this comment.
global state is a bad practice and should be refactored but I won't block the PR as it's already all over this module...
mkendall07
approved these changes
Jan 22, 2019
amuraco
pushed a commit
to amuraco/Prebid.js
that referenced
this pull request
Jan 28, 2019
…id#3470) * calling for currency file even when default rates are specified * fixed broken unit tests * added unit test to check that currency file is still requested even when default rates are set
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
…id#3470) * calling for currency file even when default rates are specified * fixed broken unit tests * added unit test to check that currency file is still requested even when default rates are set
jacekburys-quantcast
pushed a commit
to jacekburys-quantcast/Prebid.js
that referenced
this pull request
May 15, 2019
…id#3470) * calling for currency file even when default rates are specified * fixed broken unit tests * added unit test to check that currency file is still requested even when default rates are set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
We introduced a bug with the last release of currency module -- when the
defaultRatesparameter is specified, no call is made to obtain the latest rates.With this config:
Expected results are that a call should go out to jsdelivr to pull the currency file.
Actual results: it doesn't currently with 1.37+.