Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new param in tag call to ZEDO #3471

Merged
merged 39 commits into from
Feb 11, 2019
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
418baed
initial commit
skazedo Jul 12, 2018
4381ccd
updated contact and tag details
skazedo Jul 13, 2018
cd09dbc
changes ti support the renderers
skazedo Jul 16, 2018
66892e6
Merge remote-tracking branch 'upstream/master'
skazedo Jul 17, 2018
f134156
changes to pass dimId
skazedo Jul 17, 2018
c5293b7
fixed names of internal mapping
skazedo Jul 19, 2018
c9e5aca
Merge remote-tracking branch 'upstream/master'
skazedo Jul 19, 2018
ed1562f
Merge remote-tracking branch 'upstream/master'
skazedo Jul 20, 2018
bf996ec
added comment
skazedo Jul 20, 2018
b9efb20
Merge remote-tracking branch 'upstream/master'
skazedo Jul 23, 2018
c768fe5
added gdpr param to request and other fixes
skazedo Jul 23, 2018
de39585
sync main branch
skazedo Aug 6, 2018
0aeb5e7
modified api url
skazedo Aug 29, 2018
b672912
Merge remote-tracking branch 'upstream/master'
skazedo Aug 29, 2018
263d670
Merge remote-tracking branch 'upstream/master'
skazedo Sep 5, 2018
7e2f030
Merge remote-tracking branch 'upstream/master'
skazedo Sep 6, 2018
7f846dd
fix
skazedo Sep 6, 2018
e75970a
fixed the secure api call
skazedo Sep 19, 2018
92165ad
Merge remote-tracking branch 'upstream/master'
skazedo Sep 19, 2018
c605a70
rolled back video event callback till we support it
skazedo Sep 19, 2018
f78d4dc
Merge remote-tracking branch 'upstream/master'
skazedo Oct 16, 2018
76aef15
updated doc with video details
skazedo Oct 17, 2018
8483174
Merge remote-tracking branch 'upstream/master'
skazedo Oct 17, 2018
26dacc6
Merge remote-tracking branch 'upstream/master'
skazedo Oct 23, 2018
c07b17e
added bid won and timeout pixel
skazedo Oct 23, 2018
a6496ba
added testcase for bid events
skazedo Oct 24, 2018
d3e19dd
modified testcase
skazedo Oct 25, 2018
4c85915
fixed the url logged
skazedo Oct 29, 2018
cdf4148
Merge remote-tracking branch 'upstream/master' into tracking
skazedo Oct 29, 2018
3d8622a
Merge remote-tracking branch 'upstream/master'
skazedo Nov 2, 2018
064dd16
Merge remote-tracking branch 'upstream/master'
skazedo Nov 7, 2018
23b0cde
tag param values passed ot renderer
skazedo Nov 8, 2018
cbd0ea6
Merge remote-tracking branch 'upstream/master'
skazedo Nov 8, 2018
a427b52
added a conditioal check
skazedo Nov 8, 2018
fef6d50
Merge remote-tracking branch 'upstream/master'
skazedo Jan 14, 2019
42762ed
changes to support new param to adserver for purpose of tracking
skazedo Jan 14, 2019
2f3f955
passed param to renderer
skazedo Jan 16, 2019
99a0a16
missing variable defined
skazedo Jan 16, 2019
d02238d
Merge remote-tracking branch 'upstream/master'
skazedo Jan 22, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tag param values passed ot renderer
  • Loading branch information
skazedo committed Nov 8, 2018

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 23b0cde0c090d3e698f55eb355bf7739c06abc05
7 changes: 6 additions & 1 deletion modules/zedoBidAdapter.js
Original file line number Diff line number Diff line change
@@ -256,7 +256,12 @@ function getRenderer(adUnitCode, rendererId, rendererUrl, rendererOptions = {})
function videoRenderer(bid) {
// push to render queue
bid.renderer.push(() => {
var rndr = new ZdPBTag(bid.adUnitCode, bid.network, bid.width, bid.height, bid.adType, bid.vastXml);
let channelCode = utils.deepAccess(bid, 'params.0.channelCode') || 0;
let dimId = utils.deepAccess(bid, 'params.0.dimId') || 0;
let options = utils.deepAccess(bid, 'params.0.options') || {};
let channel = channelCode - (bid.network * 1000000);
var rndr = new ZdPBTag(bid.adUnitCode, bid.network, bid.width, bid.height, bid.adType, bid.vastXml, channel, dimId,
(encodeURI(utils.getTopWindowUrl()) || ''), options);
rndr.renderAd();
});
}