Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admedia adapter #3481

Merged
merged 3 commits into from
Feb 11, 2019
Merged

Admedia adapter #3481

merged 3 commits into from
Feb 11, 2019

Conversation

Elardzhi
Copy link
Contributor

Type of change

  • [x ] New bidder adapter

Description of change

Admedia bid adapter

  • test parameters for validating bids
{
  bidder: 'admedia',
  params: {
    aid: 86858
  }
}

@jaiminpanchal27 jaiminpanchal27 self-assigned this Jan 28, 2019
@bretg
Copy link
Collaborator

bretg commented Jan 28, 2019

docs PR prebid/prebid.github.io#1116

Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just one minor change requested.

@@ -0,0 +1,71 @@
import * as utils from '../src/utils';
import {registerBidder} from '../src/adapters/bidderFactory';
// import { config } from 'src/config';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove if not needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@jaiminpanchal27
Copy link
Collaborator

@Elardzhi

@jaiminpanchal27 jaiminpanchal27 merged commit 429c65e into prebid:master Feb 11, 2019
jacekburys-quantcast pushed a commit to jacekburys-quantcast/Prebid.js that referenced this pull request May 15, 2019
* Admedia adapter

* Removed a commented line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants