Get bid responses #3492
Merged
Get bid responses #3492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
January 3, 2019 12:12
added 2 commits
January 29, 2019 14:50
snapwich
requested changes
Jan 29, 2019
src/auctionManager.js
Outdated
| @@ -100,6 +100,10 @@ export function newAuctionManager() { | |||
| } | |||
| } | |||
|
|
|||
| auctionManager.getLastAuctionId = function() { | |||
| return _auctions && _auctions.length && _auctions[_auctions.length - 1].getAuctionId() | |||
There was a problem hiding this comment.
_auctions should always be an Array (it's initialized as an array (with let, might want to switch to const to make sure that's always the case)), so I think all these checks are unnecessary.
There was a problem hiding this comment.
made the change thanks
added 2 commits
January 29, 2019 16:58
jacekburys-quantcast
pushed a commit
to jacekburys-quantcast/Prebid.js
that referenced
this pull request
May 15, 2019
* 3413-Insert Iframes for user sync in body * Append Iframe as the last child * Add unit test for insertElement * utls insert element at the top by default * add unit tests for utls insert element * Insert iframe as html last child * revert package.lock changes * Override keywords in setTargetingForAst * Add resetPresetTargetingAST for setTargetingForAst * get bidresponses form last auction Id * ignore getbidresponses unit test * Add unit test for getBidResponses * fix typo * Add unit test for getBidResponses * code review changes * add minor check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
$$PREBID_GLOBAL$$.getBidResponseswill return the responses of the of the last auction if there are successful bids(i.e last auctionId is determined based on the last response returned), But last auction may not have any responses. This pull req will fix that if there are no responses in the last auctiongetBidResponseswill return empty object