Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix requestId field #3496

Merged
merged 3 commits into from
Feb 6, 2019
Merged

Fix requestId field #3496

merged 3 commits into from
Feb 6, 2019

Conversation

AntoineJac
Copy link
Contributor

after the commit (https://github.com/prebid/Prebid.js/pull/3411/files), Rubicon is no more seeing event for Server side requests.
This is due to the requestId not correctly set up as it should be the associatedBidRequest bidid not the bid response bid id.

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

after the commit (https://github.com/prebid/Prebid.js/pull/3411/files), Rubicon is no more seeing event for Server side requests.
This is due to the requestId not correctly set up as it should be the associatedBidRequest bidid not the bid response bid id.
Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM, but it looks like unit tests need to be updated for this change.

Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing unit tests, they need to be updated for this change

Copy link
Collaborator

@harpere harpere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but needs tests. (also, don't think we need to update the legacy endpoint, but don't think it hurts)

@idettman
Copy link
Contributor

After discussing with Antoine I'm approving as he mentioned

actually it is a little confusing as some code are using bid_id and sometime bidid…
I have added it some spec but haven’t changed the value as not sure it is the standard

@bretg bretg assigned harpere and unassigned idettman Feb 6, 2019
Copy link
Collaborator

@harpere harpere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harpere harpere merged commit d8754c3 into prebid:master Feb 6, 2019
jacekburys-quantcast pushed a commit to jacekburys-quantcast/Prebid.js that referenced this pull request May 15, 2019
* Fix requestId field 

after the commit (https://github.com/prebid/Prebid.js/pull/3411/files), Rubicon is no more seeing event for Server side requests.
This is due to the requestId not correctly set up as it should be the associatedBidRequest bidid not the bid response bid id.

* Update index.js

* Update prebidServerBidAdapter_spec.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants