-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix requestId field #3496
Fix requestId field #3496
Conversation
after the commit (https://github.com/prebid/Prebid.js/pull/3411/files), Rubicon is no more seeing event for Server side requests. This is due to the requestId not correctly set up as it should be the associatedBidRequest bidid not the bid response bid id.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM, but it looks like unit tests need to be updated for this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reviewing unit tests, they need to be updated for this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but needs tests. (also, don't think we need to update the legacy endpoint, but don't think it hurts)
After discussing with Antoine I'm approving as he mentioned
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Fix requestId field after the commit (https://github.com/prebid/Prebid.js/pull/3411/files), Rubicon is no more seeing event for Server side requests. This is due to the requestId not correctly set up as it should be the associatedBidRequest bidid not the bid response bid id. * Update index.js * Update prebidServerBidAdapter_spec.js
after the commit (https://github.com/prebid/Prebid.js/pull/3411/files), Rubicon is no more seeing event for Server side requests.
This is due to the requestId not correctly set up as it should be the associatedBidRequest bidid not the bid response bid id.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information