Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timmedia/timadapter 2.0 #3497

Merged
merged 8 commits into from
Feb 4, 2019

Conversation

borisjaskerovich
Copy link
Contributor

@borisjaskerovich borisjaskerovich commented Jan 30, 2019

Type of change

  • New bidder adapter

Description of change

  • test parameters for validating bids
{
"bidder":"tim",
                "params":{
                "placementCode":"testPlacementCode",
                "publisherid":"testpublisherid"
                }
}

Be sure to test the integration with your adserver using the Hello World sample page.

@shlomisut shlomisut mentioned this pull request Jan 30, 2019
2 tasks
@mike-chowla mike-chowla self-assigned this Jan 30, 2019
@mike-chowla mike-chowla self-requested a review January 30, 2019 22:17
@mike-chowla
Copy link
Contributor

I'm getting the test response now. I'm seeing a Cross-Origin error when rendering the ad because mime-type on the response to your pixel is application/json

screen shot 2019-01-30 at 2 31 13 pm

@borisjaskerovich
Copy link
Contributor Author

Hi Mike,
We fixed the Cross-Origin error now.

@mike-chowla
Copy link
Contributor

On the tracker call, I'm now seeing and SSL error:

screen shot 2019-01-31 at 5 29 53 pm

screen shot 2019-01-31 at 5 29 36 pm

@shlomisut
Copy link

shlomisut commented Feb 1, 2019

hey @mike-chowla

We changed the tracker to match the bidding domain, and missed the regional SSL config (eu worked fine )
now fixed and https://east.timmedia-hb.com/ works fine (as well as https://eu.timmedia-hb.com/ and https://sin.timmedia-hb.com/)

thanks

Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-chowla mike-chowla merged commit 0be3422 into prebid:master Feb 4, 2019
@borisjaskerovich
Copy link
Contributor Author

borisjaskerovich commented Feb 4, 2019

Thanks @mike-chowla ,
We have two questions:

  1. How do we get listed on this page: http://prebid.org/download.html ?
  2. we want to be in version 1.4 also. do we need to open another pr from that branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants