Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamoshi: Refactor GDPR consent #3507

Merged
merged 13 commits into from
Feb 4, 2019
Merged

Gamoshi: Refactor GDPR consent #3507

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7d239e5
Merge pull request #1 from prebid/master
arikkfir Aug 29, 2018
1f54dd4
Merge branch 'master' of github.com:gamoshi/Prebid.js
Sep 5, 2018
1eff2e5
Merge branch 'master' of https://github.com/prebid/Prebid.js
mmoses Oct 20, 2018
decb789
Merge remote-tracking branch 'prebid/master'
mmoses Dec 26, 2018
6e225a9
Merge remote-tracking branch 'upstream/master'
Jan 21, 2019
7bf3be1
Add support for multi-format ad units. Add favoredMediaType property …
Jan 23, 2019
fed69e9
Add tests for gdpr consent.
Jan 23, 2019
a3b2850
Add adId to outbids
Jan 24, 2019
c53757a
Modify media type resolving
Jan 27, 2019
65cbdd8
Refactor multi-format ad units handler.
Jan 28, 2019
048fe03
Merge remote-tracking branch 'upstream/master'
Feb 4, 2019
4212d2e
Merge branch 'enforce_video_branch'
Feb 4, 2019
1b33591
Modify gdpr consent existence. Add viewdeos bidder code.
Feb 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions modules/gamoshiBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@ import * as utils from '../src/utils';
import {registerBidder} from '../src/adapters/bidderFactory';
import {config} from '../src/config';
import {Renderer} from '../src/Renderer';
import {BANNER, VIDEO} from "../src/mediaTypes";
import {BANNER, VIDEO} from '../src/mediaTypes';

const ENDPOINTS = {
'viewdeos': 'https://rtb.viewdeos.com',
'cleanmedia': 'https://bidder.cleanmediaads.com',
'gamoshi': 'https://rtb.gamoshi.io',
'gambid': 'https://rtb.gamoshi.io',
Expand Down Expand Up @@ -42,7 +43,7 @@ export const helper = {

export const spec = {
code: 'gamoshi',
aliases: ['gambid', 'cleanmedia'],
aliases: ['gambid', 'cleanmedia', 'viewdeos'],
supportedMediaTypes: ['banner', 'video'],

isBidRequestValid: function (bid) {
Expand Down Expand Up @@ -76,7 +77,9 @@ export const spec = {
'ext': {}
};

if (bidderRequest.gdprConsent) {
if (bidderRequest.gdprConsent &&
bidderRequest.gdprConsent.consentString &&
bidderRequest.gdprConsent.gdprApplies) {
rtbBidRequest.ext.gdpr_consent = {
consent_string: bidderRequest.gdprConsent.consentString,
consent_required: bidderRequest.gdprConsent.gdprApplies
Expand All @@ -96,7 +99,7 @@ export const spec = {
params.favoredMediaType && this.supportedMediaTypes.includes(params.favoredMediaType);

if ((!mediaTypes || mediaTypes.banner)) {
if (!hasFavoredMediaType || params.favoredMediaType === 'banner') {
if (!hasFavoredMediaType || params.favoredMediaType === BANNER) {
const bannerImp = Object.assign({}, imp, {
banner: {
w: sizes.length ? sizes[0][0] : 300,
Expand All @@ -110,7 +113,7 @@ export const spec = {
}

if (mediaTypes && mediaTypes.video) {
if (!hasFavoredMediaType || params.favoredMediaType === 'video') {
if (!hasFavoredMediaType || params.favoredMediaType === VIDEO) {
const videoImp = Object.assign({}, imp, {
video: {
w: sizes.length ? sizes[0][0] : 300,
Expand Down