Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenX Adapter - support User ID module #3529

Merged

Conversation

idettman
Copy link
Contributor

@idettman idettman commented Feb 7, 2019

Type of change

  • Other

Description of change

Adds support for User ID module - see https://prebid.org/dev-docs/modules/userId.html

Copy link
Collaborator

@harpere harpere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bretg
Copy link
Collaborator

bretg commented Feb 7, 2019

adding folks who have recently updated this adapter for FYI and review -- @deivydas, @rjvelicaria , @lu-ruo

@stale
Copy link

stale bot commented Feb 21, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 21, 2019
@stale stale bot closed this Feb 28, 2019
@idettman idettman reopened this Apr 4, 2019
@stale stale bot removed the stale label Apr 4, 2019
@idettman idettman self-assigned this Apr 4, 2019
@idettman idettman removed their assignment Apr 5, 2019
@stale
Copy link

stale bot commented Apr 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 19, 2019
@stale stale bot closed this Apr 26, 2019
@bretg bretg reopened this Apr 29, 2019
@stale stale bot removed the stale label Apr 29, 2019
Copy link
Contributor

@jimee02 jimee02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bretg bretg merged commit 1357e96 into prebid:master May 1, 2019
jacekburys-quantcast pushed a commit to jacekburys-quantcast/Prebid.js that referenced this pull request May 15, 2019
* added universal id support to bid adapter

* added unit test for universal id support in bid adapter

* added universal id support to bid adapter

* added unit test for universal id support in bid adapter

* renamed universalID to userId

* removed merge mistake

* fix old code in test
@idettman idettman deleted the openx-adapter-universal-id-support branch June 5, 2019 23:43
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
* added universal id support to bid adapter

* added unit test for universal id support in bid adapter

* added universal id support to bid adapter

* added unit test for universal id support in bid adapter

* renamed universalID to userId

* removed merge mistake

* fix old code in test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants