Rubicon Adapter - support User ID module#3531

Merged

idettman merged 241 commits intoprebid:masterfrom rubicon-project:rubicon-adapter-universal-id-support

Apr 4, 2019

+18

Commits on Dec 10, 2018

add initial files
Isaac Dettman
committed

Commits on Dec 11, 2018

add local storage and cookie browser support functions
Isaac Dettman
committed
added additional test cases for functions related to local storage and cookie browser support
Isaac Dettman
committed
added validate config function and first unit test
Isaac Dettman
committed
add validate config test
Isaac Dettman
committed
updated local storage key value to match change to requirements/spec
Isaac Dettman
committed
updated submodule config key names to match requirements/spec
Isaac Dettman
committed
added TODO with validation logic breakdown as well as a question on how to handle both 'value' and 'storage' existing in config
Isaac Dettman
committed
add TODO addressing use-case: Publisher has integrated with OpenID on their own
Isaac Dettman
committed
fixed comment
Isaac Dettman
committed
rearranged unit tests for config functions to be grouped correctly
Isaac Dettman
committed

Commits on Dec 12, 2018

Commits on Dec 14, 2018

Commits on Dec 17, 2018

Commits on Dec 19, 2018

Commits on Dec 20, 2018

Commits on Jan 2, 2019

in-progress commit to update getId method signature with initialized consentManagement data
idettman
committed

Commits on Jan 5, 2019

Commits on Jan 6, 2019

fixed how GDPR purpose 1 permission is checked, removed decode function and read from consentData.vendorConsents.purposeConsents[1] (key value 1 is for "purpose 1")
idettman
committed

Commits on Jan 8, 2019

fix unit tests using the document cookie
idettman
committed

Commits on Jan 9, 2019

Commits on Jan 16, 2019

changed request bids hook priority to load after consentManagement
Isaac Dettman
committed

Commits on Jan 18, 2019

updated from remote master
Isaac Dettman
committed
test to resolve circle ci errors
Isaac Dettman
committed
test to resolve circle ci errors
Isaac Dettman
committed
fixed name camel case error
Isaac Dettman
committed

Commits on Jan 22, 2019

changed unifiedid decode test property name from pubcid to ttid
Isaac Dettman
committed
Merge branch 'master' of https://github.com/prebid/Prebid.js into add-universal-id-module
Isaac Dettman
committed
added universal id support to bid adapter
Isaac Dettman
committed

Commits on Jan 23, 2019

added unit test for universal id support in bid adapter
Isaac Dettman
committed
optimized last unit test added
Isaac Dettman
committed

Commits on Feb 7, 2019

add initial files
Isaac Dettman
committed
add local storage and cookie browser support functions
Isaac Dettman
committed
added additional test cases for functions related to local storage and cookie browser support
Isaac Dettman
committed
added validate config function and first unit test
Isaac Dettman
committed
add validate config test
Isaac Dettman
committed
updated local storage key value to match change to requirements/spec
Isaac Dettman
committed
updated submodule config key names to match requirements/spec
Isaac Dettman
committed
added TODO with validation logic breakdown as well as a question on how to handle both 'value' and 'storage' existing in config
Isaac Dettman
committed
add TODO addressing use-case: Publisher has integrated with OpenID on their own
Isaac Dettman
committed
fixed comment
Isaac Dettman
committed
rearranged unit tests for config functions to be grouped correctly
Isaac Dettman
committed
added logic to valid that a submodule contains a config with a value or storage obj
Isaac Dettman
committed
removed sinon mock of config.getConfig, replaced with obj literal definition in function arguments
Isaac Dettman
committed
additional use cases added to validateConfig tests
Isaac Dettman
committed
refactored init function
Isaac Dettman
committed
refactored to remove a function and reduce number of iterations of submodules and configs
Isaac Dettman
committed
add logic to pass config value obj data to adapter, also a small amount of refactoring/formatting cleanup
Isaac Dettman
committed
added configuration examples to markdown file
Isaac Dettman
committed
add add request bid hook to the initSubmodules function

idettman
authored and
Isaac Dettman
committed
added requestBidBook in preparation to test mock setup/configuration. add test for one storage type active with only one module configured to use that type

idettman
authored and
Isaac Dettman
committed
refactored requestBidHook with dependency injection for unit testing

idettman
authored and
Isaac Dettman
committed
had to revert revision to use dependency injection in the requestBidHook due to necessary use of prebid global object affecting following tests

idettman
authored and
Isaac Dettman
committed
created initial file for integration example

idettman
authored and
Isaac Dettman
committed
updated integration using brett's test page.

idettman
authored and
Isaac Dettman
committed
updated extendedBidRequestData to be a function expression, which allows watching the first element added to add the bid request hook

idettman
authored and
Isaac Dettman
committed
removed redundant constant for enabled submodules within init submodules

idettman
authored and
Isaac Dettman
committed
added retrieve storage value and logic to call submodule.getId if stored value does not exist

idettman
authored and
Isaac Dettman
committed
added submodule getId fallback when storage value does not exist

idettman
authored and
Isaac Dettman
committed
extended addUnit bid requests with universalId data, add logging for invalid config storage type, revised commenting

idettman
authored and
Isaac Dettman
committed
add logic to set storage and pass decoded data in getId response handler

idettman
authored and
Isaac Dettman
committed
updated initModules unit test mock data to fix broken tests from previous module additions/updates

idettman
authored and
Isaac Dettman
committed
updated comments for consistency

idettman
authored and
Isaac Dettman
committed
fixed module description comment

idettman
authored and
Isaac Dettman
committed
add overrideId interface and implementation to the pubCommonId submodule

idettman
authored and
Isaac Dettman
committed
fix to only check for override method value if submodule has a configKey set in the config

idettman
authored and
Isaac Dettman
committed
added unit test for submodule override method implementation

idettman
authored and
Isaac Dettman
committed
completed the pubCommonId submodule getId implementation; changed pubCommonId submodule default expires value to today + 8 years

idettman
authored and
Isaac Dettman
committed
changed openId submodule default expires value to today + 8 years; added final todo comments, pertaining to openId submodule decode and getId methods

idettman
authored and
Isaac Dettman
committed
fixed formatting to correct linting errors during building

idettman
authored and
Isaac Dettman
committed
update jsdoc comments for IdSubmodule

idettman
authored and
Isaac Dettman
committed
added jsdoc comments for overrideId submodule interface method

idettman
authored and
Isaac Dettman
committed
changed the overrideId return value conditional to require a valid object, added a todo note to investigate using separate instance callbacks to handle multiple timers for syncDelay/auctionDelay

idettman
authored and
Isaac Dettman
committed
add ajax request to openId submodule getId, awaiting values for request params and response structure and format for storage and structure for adding to bid requests

idettman
authored and
Isaac Dettman
committed
updated openId submodule getId error logging and callback handling

idettman
authored and
Isaac Dettman
committed
fix obj path access for syncDelay, updated example file with pubCommonId configured

idettman
authored and
Isaac Dettman
committed
fix for broken unit tests resulting from update of overrideId addition to submodule interface

idettman
authored and
Isaac Dettman
committed
replace use of built-in array find method, with import of 'core-js/library/fn/array/find', fixes/updates for integration example for module

idettman
authored and
Isaac Dettman
committed
refactored config handling in initSubmodules to accept a plain js object opposed to a prebid Config object (this simplifies testing setup)

idettman
authored and
Isaac Dettman
committed
created init method to wrap initSubmodules with config

idettman
authored and
Isaac Dettman
committed
refactored module's config to watch/handle changes

idettman
authored and
Isaac Dettman
committed
removed overrideId submodule interface, change openId to unifiedId

idettman
authored and
Isaac Dettman
committed
update getId and decode uid data structure also updated integration example

idettman
authored and
Isaac Dettman
committed
updated object structure for universal ids that is added to bid request, add universalID object handling to rubiconBidAdapter

idettman
authored and
Isaac Dettman
committed
updated markdown example configuration

idettman
authored and
Isaac Dettman
committed
fix for syncDelay, added auction end listener before setting syncDelay timer

idettman
authored and
Isaac Dettman
committed
update to prepare universalID object if adUnits exists

idettman
authored and
Isaac Dettman
committed
add gdpr consent data to request bids hook, warn on not found, info if found

idettman
authored and
Isaac Dettman
committed
add test for valid gdpr consent string, exits universal id module on fail

idettman
authored and
Isaac Dettman
committed
update gdpr consent to check gdprApplies, add cmp code to integration example. update init to use dependency injection

idettman
authored and
Isaac Dettman
committed
implemented test for gdpr consent to store locally (purpose #1 )

idettman
authored and
Isaac Dettman
committed
added consentString decode to check for purpose #1 (user consents to have data stored locally)

idettman
authored and
Isaac Dettman
committed
fix initSubmodule function arguments for changed signature

idettman
authored and
Isaac Dettman
committed
changed submodule getId method signature to pass a consentData argument

idettman
authored and
Isaac Dettman
committed
tests update with dependency container

idettman
authored and
Isaac Dettman
committed
update spec to un-comment disabled expect statement

idettman
authored and
Isaac Dettman
committed
in-progress DI conversion

idettman
authored and
Isaac Dettman
committed
update to fix test missing dependency for utils

idettman
authored and
Isaac Dettman
committed
removed getIdCallbackHandler function because it was inlined within initSubmodules. refactored dependencyContainer argument names to dependencies

idettman
authored and
Isaac Dettman
committed
add unit test case for configurations that define invalid storage.type values (only cookie or html5 are valid)

idettman
authored and
Isaac Dettman
committed
fixes for html5 storage in module and unit tests. temp comment-out for gdpr test in requestBid hook as it's being refactored into getId submodule methods

idettman
authored and
Isaac Dettman
committed
fixes for html5 storage in module and unit tests. temp comment-out for gdpr test in requestBid hook as it's being refactored into getId submodule methods

idettman
authored and
Isaac Dettman
committed
added opt_out cookie logic to init

idettman
authored and
Isaac Dettman
committed
in-progress commit to update getId method signature with initialized consentManagement data

idettman
authored and
Isaac Dettman
committed
changed priority to consent management module's value + 1

idettman
authored and
Isaac Dettman
committed
updated both submodule getId functions with consent data handling.

idettman
authored and
Isaac Dettman
committed
update hasGDPRConsent to remove unnecessary test for consentData obj since it's tested outside of function, removed utils from dependency injection

idettman
authored and
Isaac Dettman
committed
update to move local declarations outside if block, added local var for log prefix since it was accessed more than twice

idettman
authored and
Isaac Dettman
committed
changed log prefix to build the string locally instead of passing through getIdData obj

idettman
authored and
Isaac Dettman
committed
bug fix for request bid hook priority race condition

idettman
authored and
Isaac Dettman
committed
removed consentData prop from init dependencies obj, updated jsdoc comments removing consentData prop

idettman
authored and
Isaac Dettman
committed
removed consentData prop from init arguments

idettman
authored and
Isaac Dettman
committed
update integration example to test gdpr cmpApi type of 'static'

idettman
authored and
Isaac Dettman
committed
refactor to combine request bid hooks into single hook, also other opts and formatting changes

idettman
authored and
Isaac Dettman
committed
additions/updates to logging, additions/updates to jsdoc comments, various refactoring and formatting updates

idettman
authored and
Isaac Dettman
committed
fixed how GDPR purpose 1 permission is checked, removed decode function and read from consentData.vendorConsents.purposeConsents[1] (key value 1 is for "purpose 1")

idettman
authored and
Isaac Dettman
committed
fix for hasGDPRConsent functions, changed object prop accessor name from 'consentData.vendorConsent' to 'consentData.vendorData'

idettman
authored and
Isaac Dettman
committed
small changes to log messages and code formatting

idettman
authored and
Isaac Dettman
committed
changed submodule property configKey to configName for consistency with the submodule config property name

idettman
authored and
Isaac Dettman
committed
updated logging message text and small format change

idettman
authored and
Isaac Dettman
committed
updated jsdoc comment to reduce line length

idettman
authored and
Isaac Dettman
committed
formatting fix and jsdoc update

idettman
authored and
Isaac Dettman
committed
reverted changes to support universal id in rubiconBidAdapter, will open a separate PR for the adapter code changes.

idettman
authored and
Isaac Dettman
committed
added logging messages to catch statements

idettman
authored and
Isaac Dettman
committed
fix unit tests using the document cookie

idettman
authored and
Isaac Dettman
committed
fix to extra module name in log message

idettman
authored and
Isaac Dettman
committed
changed function return type array to undefined on invalid config

idettman
authored and
Isaac Dettman
committed
moved encodeURIComponenent and decodeURIComponenent into setCookie and getCookie

idettman
authored and
Isaac Dettman
committed
refactor to resolve issues creating certain unit tests

idettman
authored and
Isaac Dettman
committed
add tests for config variations, small fixes for issues found writing tests

idettman
authored and
Isaac Dettman
committed
removed debug console.log statements

idettman
authored and
Isaac Dettman
committed
removed set initializedSubmodules value in init

idettman
authored and
Isaac Dettman
committed
fix to remove test cookie from spec, updated example with submodule config value object

idettman
authored and
Isaac Dettman
committed
added tests checking that config submodule props create correct number of submodules

idettman
authored and
Isaac Dettman
committed
added test for syncDelay config update

idettman
authored and
Isaac Dettman
committed
fixes for LGTM and imports for src are now relative

idettman
authored and
Isaac Dettman
committed
formatting fix semicolon

idettman
authored and
Isaac Dettman
committed
test reverted to debug circleci failure

idettman
authored and
Isaac Dettman
committed
changed request bids hook priority to load after consentManagement
Isaac Dettman
committed
test to resolve circle ci errors
Isaac Dettman
committed
test to resolve circle ci errors
Isaac Dettman
committed
fixed name camel case error
Isaac Dettman
committed
changed unifiedid decode test property name from pubcid to ttid
Isaac Dettman
committed
added universal id support to bid adapter
Isaac Dettman
committed
added unit test for universal id support in bid adapter
Isaac Dettman
committed
optimized last unit test added
Isaac Dettman
committed
renamed universalID to userId
Isaac Dettman
committed
Merge remote-tracking branch 'origin/rubicon-adapter-universal-id-support' into rubicon-adapter-universal-id-support
Isaac Dettman
committed
removed file from universal id branch
Isaac Dettman
committed
Merge branch 'master' of https://github.com/prebid/Prebid.js into rubicon-adapter-universal-id-support
Isaac Dettman
committed

Commits on Apr 4, 2019

Merge branch 'master' of https://github.com/prebid/Prebid.js into rubicon-adapter-universal-id-support
Isaac Dettman
committed