Sonobi Adapter - support User ID module #3532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 23, 2019 10:25
…ort' into sonobi-adapter-universal-id-support # Conflicts: # test/spec/modules/sonobiBidAdapter_spec.js
harpere
reviewed
Feb 7, 2019
|
Updated to address comment by @harpere |
|
Adding Sobobi folks to have a chance to review: @JonGoSonobi , @edahood-sonobi |
harpere
reviewed
Feb 7, 2019
JonGoSonobi
approved these changes
Feb 7, 2019
|
LGTM |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
…com/rubicon-project/Prebid.js; branch 'master' of https://github.com/prebid/Prebid.js into sonobi-adapter-universal-id-support
jacekburys-quantcast
pushed a commit
to jacekburys-quantcast/Prebid.js
that referenced
this pull request
May 15, 2019
* added universal id support to bid adapter * added unit test for universal id support in bid adapter * added universal id support to bid adapter * added unit test for universal id support in bid adapter * renamed universalID to userId * removed merge error * test fix remove userId prop when completed * updated to prioritize hfa value from hfa over userId.pubcid or crumbs.pubcid * updated userId conditional as recommended
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Adds support for User ID module - see https://prebid.org/dev-docs/modules/userId.html