Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checking usConfig.enableOverride value before returning #3542

Merged
merged 1 commit into from
Feb 12, 2019
Merged

checking usConfig.enableOverride value before returning #3542

merged 1 commit into from
Feb 12, 2019

Conversation

pm-harshad-mane
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

#3320

@pm-harshad-mane
Copy link
Contributor Author

Hello @mkendall07 and @jsnellbaker
Could you please review this PR?

@jsnellbaker jsnellbaker self-requested a review February 12, 2019 14:23
@jsnellbaker jsnellbaker self-assigned this Feb 12, 2019
@jsnellbaker jsnellbaker added the needs 2nd review Core module updates require two approvals from the core team label Feb 12, 2019
mkendall07
mkendall07 approved these changes Feb 12, 2019
View reviewed changes
Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker merged commit b55dacf into prebid:master Feb 12, 2019
@pm-harshad-mane
Copy link
Contributor Author

Thank you @mkendall07 and @jsnellbaker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnellbaker jsnellbaker jsnellbaker approved these changes

@mkendall07 mkendall07 mkendall07 approved these changes

Assignees

@jsnellbaker jsnellbaker

Labels
needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pm-harshad-mane @mkendall07 @jsnellbaker