-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add buyer data to Index Exchange bid responses #3585
Conversation
The circleci test failure doesn't appear to be caused by this PR, as far as I can tell. |
you might need to rebase on master to fix the circle CI error. |
Following format specified in prebid#3115
2722225
to
39cf8e0
Compare
@mkendall07 This looks good to merge into the next release. One observation is that it doesn't appear that these ext params make the Prebid Server response. This would prevent the data from reaching the analytics module for Ozone. Has this been tested and are there any concerns here? |
@ix-prebid-support This PR is purely to make buyer data available to the client-side adapter. It's only been tested in that context. I haven't considered what changes would be required to support analytics in Ozone as that isn't in the scope of the PR. |
@kelvin-chappell Understood, and appreciate the quick clarification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks everyone for their input.
Following format specified in prebid#3115
Following format specified in prebid#3115
Type of change
Description of change
Adds buyer data to Index Exchange responses, following the format specified in #3115.
We have already made this change to our fork, here.
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information
/cc @ix-prebid-support