Submit Brightcom Bid Adapter

[vyatsun]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

• test parameters for validating bids

{
  bidder:  'brightcom',
  params: {
    publisherId: 2141020
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

• contact email of the adapter’s maintainer: vladislavy@brightcom.com
• official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

• prebid/prebid.github.io#1186

[jsnellbaker]

Hi @vyatsun

While trying to test the adapter, I was encountering a CORS error when it was requesting the bids.

Below is a copy of the error message for reference:

Access to XMLHttpRequest at 'https://brightcombid.marphezis.com/hb' from origin 'http://test.localhost:9999' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

Can you please take a look? If you need any additional details on the request or payload, please let me know.

[vyatsun]

Hi @jsnellbaker

Could you please try again, and make sure you're sending the 'Origin' and 'User-Agent' headers?

If it still doesn't work for you, please share the request details.

[jsnellbaker]

Hi @vyatsun

Thanks for making the update; I can verify that the adapter is successfully returning a bid now with the test params and everything looked good from that perspective.

However there is another item that should be ideally addressed before we merge the adapter. I've made a note below at the relevant area in the code. Can you please take a look when possible?

[jsnellbaker]

This function is eventually going to be deprecated, so it shouldn't be used if possible.

We have setup an alternative feature with this type of information that can be used instead. The associated domain data can be accessed via the bidderRequest.refererInfoobject.

The following page provides some additional details on the object and its data points if you want to review further:
http://prebid.org/dev-docs/bidder-adaptor.html#referrers

[vyatsun]

Hi @jsnellbaker

I've removed the utils.getTopWindowLocation() call.

[jsnellbaker]

Hi @vyatsun Thanks for making the updates; LGTM