Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonobi - Analytics Adapter #3615

Merged
merged 4 commits into from
Mar 18, 2019
Merged

Sonobi - Analytics Adapter #3615

merged 4 commits into from
Mar 18, 2019

Conversation

JonGoSonobi
Copy link
Contributor

Type of change

  • Other
    New Analytics Adapter

Description of change

Added an analytics Adapter for sonobi

pbjs.enableAnalytics({
                  provider: 'sonobi',
                     options: {
                  	     pubId: 'ffBB352',
                         siteId: 57463,
                         delay: 300
                     }
                })

idettman
idettman approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer more tests, but it covers the events so LGTM

@idettman idettman merged commit 4fd7c47 into prebid:master Mar 18, 2019
pycnvr pushed a commit to conversant/Prebid.js that referenced this pull request Apr 4, 2019
@JonGoSonobi @pycnvr
Sonobi - Analytics Adapter (prebid#3615)
eecef4d 
* Initial release of Sonobi Analytics adapter.

* Removed withCredentials on the sendData requests. Improved unit tests

* unit tests working.

* remove unneeded array.from
jacekburys-quantcast pushed a commit to jacekburys-quantcast/Prebid.js that referenced this pull request May 15, 2019
@JonGoSonobi @jacekburys-quantcast
Sonobi - Analytics Adapter (prebid#3615)
5b64b51 
* Initial release of Sonobi Analytics adapter.

* Removed withCredentials on the sendData requests. Improved unit tests

* unit tests working.

* remove unneeded array.from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idettman idettman idettman approved these changes

Assignees

@idettman idettman

Labels
adapter support LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JonGoSonobi @idettman @edahood-sonobi