Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added an optional auctionId parameter to requestBids #3622

Merged
merged 2 commits into from
Apr 9, 2019
Merged

added an optional auctionId parameter to requestBids #3622

merged 2 commits into from
Apr 9, 2019

Conversation

PascalSalesch
Copy link
Contributor

Type of change

  • Feature

Description of change

Added an optional parameter auctionId to the requestBids api.
This makes it easier for us to track cross prebid auctions (i.e.: auctions where prebid adapters compete with other header bidding partners).

ToDo: Docu update

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide a link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/

Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I see the use case for this. This would open up for some bad behavior if for instance you just send 42 for each auctionId.

@mkendall07
Copy link
Member

@PascalSalesch
after thinking about this some more I think we can approve this type of a change. For some reason Travis-ci is running but we don't use it anymore. This could be caused by an older master branch. Can you rebase your changes and submit? I think that should resolve the travis-ci build error.
Also we will need a documentation PR for this as it affects the pub API. Thanks

@PascalSalesch
Copy link
Contributor Author

PascalSalesch commented Mar 25, 2019

okay, I will open the PR later.

what changed your mind, if you don't mind me asking? I was thinking of other use cases besides my edge case but wasn't sure. It does allow bad behavior but in a very unintuitive way (IMO)

@mkendall07
Copy link
Member

mkendall07 commented Mar 26, 2019

@bretg changed my mind ;) well he just pointed out that it could be somewhat common to use another wrapper in tandem with Prebid.js (think if you are using Amazon for example or another one that isn't supported by prebid.js).

Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just need a docs PR.

@mkendall07 mkendall07 added needs 2nd review Core module updates require two approvals from the core team needs docs labels Mar 26, 2019
Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bretg
Copy link
Collaborator

bretg commented Mar 26, 2019

Minimal docs PR -- prebid/prebid.github.io#1225

I don't think this use case is prevalent enough at this point to warrant a full example. But anyone who disagrees is free to submit a more substantial docs update.

@bretg bretg removed the needs docs label Mar 26, 2019
@jsnellbaker
Copy link
Collaborator

@PascalSalesch Can you please resolve the conflicts?

@jaiminpanchal27 jaiminpanchal27 merged commit a53deb9 into prebid:master Apr 9, 2019
@PascalSalesch PascalSalesch deleted the feat/requestbid_auctionid_parameter branch April 25, 2019 12:27
jacekburys-quantcast pushed a commit to jacekburys-quantcast/Prebid.js that referenced this pull request May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants