-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added an optional auctionId parameter to requestBids #3622
added an optional auctionId parameter to requestBids #3622
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I see the use case for this. This would open up for some bad behavior if for instance you just send 42
for each auctionId.
@PascalSalesch |
okay, I will open the PR later. what changed your mind, if you don't mind me asking? I was thinking of other use cases besides my edge case but wasn't sure. It does allow bad behavior but in a very unintuitive way (IMO) |
@bretg changed my mind ;) well he just pointed out that it could be somewhat common to use another wrapper in tandem with Prebid.js (think if you are using Amazon for example or another one that isn't supported by prebid.js). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just need a docs PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Minimal docs PR -- prebid/prebid.github.io#1225 I don't think this use case is prevalent enough at this point to warrant a full example. But anyone who disagrees is free to submit a more substantial docs update. |
@PascalSalesch Can you please resolve the conflicts? |
Type of change
Description of change
Added an optional parameter
auctionId
to the requestBids api.This makes it easier for us to track cross prebid auctions (i.e.: auctions where prebid adapters compete with other header bidding partners).
ToDo: Docu update
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide a link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/