Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADman Media new bidder adapter #3639

Merged
merged 4 commits into from
Mar 22, 2019
Merged

ADman Media new bidder adapter #3639

merged 4 commits into from
Mar 22, 2019

Conversation

admanmedia
Copy link
Contributor

  • New bidder adapter

  • test parameters for validating bids

{
  bidder: 'adman',
  params: {
    id: 5ae1b797
  }
}

@bretg
Copy link
Collaborator

bretg commented Mar 18, 2019

Docs PR at prebid/prebid.github.io#1209

idettman
idettman reviewed Mar 18, 2019
View reviewed changes
modules/admanBidAdapter.js Show resolved Hide resolved
modules/admanBidAdapter.js Show resolved Hide resolved
modules/admanBidAdapter.js Outdated Show resolved Hide resolved
modules/admanBidAdapter.js Outdated Show resolved Hide resolved
modules/admanBidAdapter.js Outdated Show resolved Hide resolved
modules/admanBidAdapter.js Outdated Show resolved Hide resolved
idettman
idettman suggested changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@idettman idettman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates LGTM

idettman
idettman suggested changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove console.log

test/spec/modules/admanBidAdapter_spec.js Show resolved Hide resolved
@idettman
Copy link
Contributor

All changes look good, however I see there is a console.log used in the test file, this needs to be removed. Once this is completed, I'll approve

idettman
idettman approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idettman idettman merged commit e604ab3 into prebid:master Mar 22, 2019
pycnvr pushed a commit to conversant/Prebid.js that referenced this pull request Apr 4, 2019
@admanmedia @pycnvr
ADman Media new bidder adapter (prebid#3639)
d0f8a3d 
* Add Adman bid adapter

* Add supportedMediaTypes property

* Update ADman Media bidder adapter

* Remove console.log
jacekburys-quantcast pushed a commit to jacekburys-quantcast/Prebid.js that referenced this pull request May 15, 2019
@admanmedia @jacekburys-quantcast
ADman Media new bidder adapter (prebid#3639)
bdb17cf 
* Add Adman bid adapter

* Add supportedMediaTypes property

* Update ADman Media bidder adapter

* Remove console.log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkatogi mkatogi mkatogi left review comments

@idettman idettman idettman approved these changes

Assignees

@idettman idettman

Labels
reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@admanmedia @bretg @idettman @mkatogi @minokem