Add hb_uuid and hb_cache_id back to dfp module #3668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretg
approved these changes
Mar 22, 2019
bretg
added
the
needs 2nd review
mkendall07
approved these changes
Mar 25, 2019
| @@ -158,6 +158,9 @@ function getCustParams(bid, options) { | |||
|
|
|||
| const optCustParams = deepAccess(options, 'params.cust_params'); | |||
| let customParams = Object.assign({}, | |||
| { hb_uuid: bid && bid.videoCacheKey }, | |||
There was a problem hiding this comment.
can you add a comment here with a link to the issue so folks looking at the code will understand?
jsnellbaker
approved these changes
Mar 26, 2019
pycnvr
pushed a commit
to conversant/Prebid.js
that referenced
this pull request
Apr 4, 2019
* Add hb_uuid and hb_cache_id back to module * added comment
jacekburys-quantcast
pushed a commit
to jacekburys-quantcast/Prebid.js
that referenced
this pull request
May 15, 2019
* Add hb_uuid and hb_cache_id back to module * added comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Add hb_uuid and hb_cache_id back to dfp module
Fixes #3664