support userId module #3675
Merged
support userId module #3675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge upstream changes into my fork
merge prebid master into my fork
| if (request && request.userId && typeof request.userId === 'object') { | ||
| userId = request.userId; | ||
| } | ||
| return userId; |
There was a problem hiding this comment.
why don't you just return userId.pucid if it exists?
jaiminpanchal27
approved these changes
Mar 26, 2019
pycnvr
pushed a commit
to conversant/Prebid.js
that referenced
this pull request
Apr 4, 2019
* use unit id being sent instead of hard coded auid * make multiple requests * removes commented out code. adds aus param back * hardcodes vht, vwd, aus * arrays should have commas * adds aus check to test * updates md file with new sizes syntax * updates md file with new sizes syntax * adds note on md about size option * size updates * adds prebid consortium id
jacekburys-quantcast
pushed a commit
to jacekburys-quantcast/Prebid.js
that referenced
this pull request
May 15, 2019
* use unit id being sent instead of hard coded auid * make multiple requests * removes commented out code. adds aus param back * hardcodes vht, vwd, aus * arrays should have commas * adds aus check to test * updates md file with new sizes syntax * updates md file with new sizes syntax * adds note on md about size option * size updates * adds prebid consortium id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Adds support for User ID module