Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust TTL for MANTIS adapter #3676

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Adjust TTL for MANTIS adapter #3676

merged 2 commits into from
Mar 25, 2019

Conversation

parisholley
Copy link
Contributor

Existing adapter has incorrect TTL of 24 hours hard coded, change will allow for TTL overriding by server response at bid or global level

bretg
bretg approved these changes Mar 25, 2019
View reviewed changes
Copy link
Collaborator

@bretg bretg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks. A smaller default TTL might still be desirable, but assuming your responses normally contain TTLs in the order of minutes rather than hours, the net effect is what we're looking for.

@bretg bretg merged commit 3e5190d into prebid:master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretg bretg bretg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parisholley @bretg