Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Grid Bid Adapter #3681

Merged
merged 11 commits into from
Apr 9, 2019
Merged

Update Grid Bid Adapter #3681

merged 11 commits into from
Apr 9, 2019

Conversation

TheMediaGrid
Copy link
Contributor

Type of change

  • Bugfix
  • Feature

Description of change

Added support possibility to receive in config several identical uids for one slot.

@stale
Copy link

stale bot commented Apr 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 9, 2019
@TheMediaGrid
Copy link
Contributor Author

Hello @robertrmartinez. Could you, please, review this?

@stale stale bot removed the stale label Apr 9, 2019
@robertrmartinez
Copy link
Collaborator

@TheMediaGrid Will get it done now!

Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertrmartinez robertrmartinez merged commit d877177 into prebid:master Apr 9, 2019
jacekburys-quantcast pushed a commit to jacekburys-quantcast/Prebid.js that referenced this pull request May 15, 2019
* Added Grid Bid Adapter

* remove priceType from TheMediaGrid Bid Adapter

* Add video support in Grid Bid Adapter

* Added test parameter for video slot

* update Grid Bid Adapter to set size in response bid

* Update Grid Bid Adapter to support identical uids in parameters

* Fix typo in test file for Grid Bid Adapter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants