Rvr 2369 add trackable add ad units event #3691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handled in separate PR prebid#3683
2 tasks
|
Thanks for splitting out this change from the other PR. While I was looking over the overall logic, I noticed that there is another event that's not handled by the Since we're fixing one, can you update the PR to also fix the other? |
|
@jsnellbaker I can do that. I will push the changes soon. |
|
@jsnellbaker I added |
jsnellbaker
approved these changes
Apr 1, 2019
There was a problem hiding this comment.
@AlessandroDG Thanks for making the updates; the browserstack tests ran fine on my end when I ran them locally.
jsnellbaker
added
needs 2nd review
|
@jsnellbaker you're welcome! |
idettman
added
LGTM
and removed
needs 2nd review
jacekburys-quantcast
pushed a commit
to jacekburys-quantcast/Prebid.js
that referenced
this pull request
May 15, 2019
* RVR-2177 - Refactor events handling * RVR-2087 - Inject pbjsGlobalVariable into rivraddon * RVR-2087 - update adapterManager dependency * RVR-2087 - Add ADD_AD_UNITS to Prebid.JS trackable events * RVR-2369 - Update package-lock.json * RVR-2369 - Revert rivrAnalyticsAdapter changed Handled in separate PR prebid#3683 * RVR-2369 - Add REQUEST_BIDS to trackable events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Add ADD_AD_UNITS to trackable events.
Other information
Requested by @jsnellbaker in #3683