Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rvr 2369 add trackable add ad units event #3691

Merged
merged 7 commits into from
Apr 1, 2019
Merged

Rvr 2369 add trackable add ad units event #3691

merged 7 commits into from
Apr 1, 2019

Conversation

AlessandroDG
Copy link
Contributor

Type of change

  • Feature

Description of change

Add ADD_AD_UNITS to trackable events.

Other information

Requested by @jsnellbaker in #3683

@AlessandroDG AlessandroDG mentioned this pull request Mar 28, 2019
Merged
2 tasks
@jsnellbaker jsnellbaker self-requested a review March 28, 2019 16:41
@jsnellbaker jsnellbaker self-assigned this Mar 28, 2019
@jsnellbaker
Copy link
Collaborator

Hi @AlessandroDG

Thanks for splitting out this change from the other PR. While I was looking over the overall logic, I noticed that there is another event that's not handled by the AnalyticsAdapter; the REQUEST_BIDS event.

Since we're fixing one, can you update the PR to also fix the other?

@AlessandroDG
Copy link
Contributor Author

@jsnellbaker I can do that. I will push the changes soon.

@AlessandroDG
Copy link
Contributor Author

@jsnellbaker I added REQUEST_BIDS to the trackable events.
There is the usual issue with circleci running on my company's instance, tests should pass if executed locally or on your circleci instance.

jsnellbaker
jsnellbaker approved these changes Apr 1, 2019
View reviewed changes
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlessandroDG Thanks for making the updates; the browserstack tests ran fine on my end when I ran them locally.

@jsnellbaker jsnellbaker added needs 2nd review Core module updates require two approvals from the core team and removed needs review labels Apr 1, 2019
@jsnellbaker jsnellbaker assigned idettman and unassigned jsnellbaker Apr 1, 2019
@AlessandroDG
Copy link
Contributor Author

@jsnellbaker you're welcome!

idettman
idettman approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idettman idettman added LGTM and removed needs 2nd review Core module updates require two approvals from the core team labels Apr 1, 2019
@idettman idettman merged commit 6723904 into prebid:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idettman idettman idettman approved these changes

@jsnellbaker jsnellbaker jsnellbaker approved these changes

Assignees

@idettman idettman

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlessandroDG @jsnellbaker @idettman