Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Telaria Adapter: GDPR support #3701

Merged
merged 22 commits into from
Apr 5, 2019
Merged

Telaria Adapter: GDPR support #3701

merged 22 commits into from
Apr 5, 2019

Conversation

telariaEng
Copy link
Contributor

@telariaEng telariaEng commented Apr 1, 2019 •
edited
Loading

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Added gdpr support

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer: github@telaria.com
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

tremorvideo and others added 22 commits July 31, 2018 19:58
@tremorvideo
Added telaria bid adapter
5dcf4b5
@tremorvideo
more documentation
0a19ea2
@tremorvideo
Added more test cases. And improved some code in the adapter
e1d19e4
@tremorvideo
Removed the check for optional params, they are handled in the server…
0863824 
…. Also updated certain param names used in the test spec.
@tremorvideo
added some spaces to fix CircleCI tests
cb0973a
@tremorvideo
added some spaces to fix CircleCI tests
836779c
@tremorvideo
fixed code indentation in /spec/AnalyticsAdapter_spec.js which causin…
850c4f4 
…g the CircleCI tests to fail.
@tremorvideo
Reverted the changes
ad01373
@tremorvideo
merged with prebid master.
df23a42
@tremorvideo
merged with prebid master.
de868c1
@tremorvideo
creative Id is required when we build a response but our server doesn…
dd996a9 
…'t always have the crid, so using a sentinel value when we don't have the crid.
@tremorvideo
- removed an un used method
7ef41b9 
- Removed the package-lock file.
@tremorvideo
Merge https://github.com/prebid/Prebid.js
d7b95e6 
# Conflicts:
#	package-lock.json
Merge branch 'master' of https://github.com/prebid/Prebid.js
58cc7ce
merging to master
81ec17a
updated telaria bid adapter to use player size provided by the bid.me…
cebc764 
…diaTypes.video.playerSize instead of bid.sizes.

prebid#3331
- removed the requirement for having player size
7d617a7 
- updated the test spec to reflect the above change
- removed changes to the package-lock.json file.
added a param to the ad call url to let us know that the request is c…
012a77b 
…oming via hb.
to lower casing the bidder code.
178c072
Merge branch 'master' of https://github.com/prebid/Prebid.js
fb10552 
# Conflicts:
#	modules/telariaBidAdapter.js
Merge branch 'master' of https://github.com/prebid/Prebid.js
7c6f20c 
# Conflicts:
#	modules/telariaBidAdapter.js

Added GDPR support
Sending the gdpr & gdpr consent string only if they're defined
32831bf
@harpere harpere added the LGTM label Apr 5, 2019
@harpere harpere merged commit 111b82f into prebid:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harpere harpere harpere approved these changes

Assignees
No one assigned
Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@telariaEng @harpere @tremorvideo