Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sortable - Analytics Adapter #3705

Merged
merged 1 commit into from Apr 16, 2019
Merged

Sortable - Analytics Adapter #3705

merged 1 commit into from Apr 16, 2019

Conversation

danielMi16
Copy link
Contributor

Type of change

  • Other
    New Analytics Adapter

Description of change

Added Sortable Analytics adapter

pbjs.enableAnalytics({
    'provider': 'sortable',
    'options': {
      'siteId': 'site.com'
    }
});

@robertrmartinez
Copy link
Collaborator

Taking a look at this now

@danielMi16
Copy link
Contributor Author

@robertrmartinez Are there any questions?

robertrmartinez
robertrmartinez approved these changes Apr 15, 2019
View reviewed changes
Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Did you add a PR for the docs @danielMi16

@danielMi16
Copy link
Contributor Author

@robertrmartinez I just did: prebid/prebid.github.io#1265

@robertrmartinez robertrmartinez merged commit 2431715 into prebid:master Apr 16, 2019
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
@danielMi16
Sortable - Analytics Adapter (prebid#3705)
3528d49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertrmartinez robertrmartinez robertrmartinez approved these changes

Assignees

@robertrmartinez robertrmartinez

Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielMi16 @robertrmartinez @harpere