Yieldnexus: Add video player size #3727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging back with prebid master
Add unit test.
|
@sa1omon Can you please fix the linting error?
|
Hi @robertrmartinez, |
jacekburys-quantcast
pushed a commit
to jacekburys-quantcast/Prebid.js
that referenced
this pull request
May 15, 2019
* Add support for multiple media types. Add test coverage. * Add support for multiple media types. Add test coverage. * Modify multi-format ads handler. Modify tests. * Rename yieldnexus bid adapter to fix download issue * Set video player according to playerSize (if given). Add unit test. * Fix lint issues
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
* Add support for multiple media types. Add test coverage. * Add support for multiple media types. Add test coverage. * Modify multi-format ads handler. Modify tests. * Rename yieldnexus bid adapter to fix download issue * Set video player according to playerSize (if given). Add unit test. * Fix lint issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Set the correct video player size if playerSize property is defined.
Add a unit test.