Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change matching url #3730

Merged
merged 1 commit into from
Apr 19, 2019
Merged

change matching url #3730

merged 1 commit into from
Apr 19, 2019

Conversation

ignat-one
Copy link
Contributor

Type of change

  • Bugfix

Description of change

Changed protocol in matching url from 'http://' to '//'.

Be sure to test the integration with your adserver using the Hello World sample page.

@ignat-one
Copy link
Contributor Author

ignat-one commented Apr 15, 2019

@mike-chowla , is everything okay? Will you accept pull request?

@ignat-one
Copy link
Contributor Author

@jsnellbaker ???

@jsnellbaker jsnellbaker self-requested a review April 19, 2019 16:48
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker merged commit 69f114a into prebid:master Apr 19, 2019
jacekburys-quantcast pushed a commit to jacekburys-quantcast/Prebid.js that referenced this pull request May 15, 2019
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants