Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stv adapter #3737

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Conversation

onlsol
Copy link
Contributor

@onlsol onlsol commented Apr 10, 2019

Type of change

  • [ x] New bidder adapter

Description of change

New adapter

  • test parameters for validating bids

mediaTypes: {
  video: {
   playerSize: [640, 480],
   context: 'instream'
   }
 },
bids: [{
--
   bidder: 'stv',
   params: {
      placement: 'prer%3D613'
    }
  }]


Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • [x ] official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @onlsol Thanks for submitting this adapter.

Overall everything looks good. The only thing I would ask to update is to remove the commented lines of code from the adapter file.

We should all set then.

@onlsol
Copy link
Contributor Author

onlsol commented Apr 11, 2019

@jsnellbaker Done. I pushed new commit with changes.

@jsnellbaker
Copy link
Collaborator

@onlsol Thanks for making the update. I ran the circleCI tests locally and found everything was passing successfully. It only failed here because it was trying to run them with a different account that didn't have access to browserstack.

@jsnellbaker jsnellbaker merged commit 220f80f into prebid:master Apr 11, 2019
@onlsol
Copy link
Contributor Author

onlsol commented Apr 11, 2019

Thank You

@bretg
Copy link
Collaborator

bretg commented Apr 15, 2019

Docs PR prebid/prebid.github.io#1255

VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
* add stv adapter

* remove comments from adapter file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants