Sonobi Adapter - Support UnifiedId/tradedesk from user id module #3743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnellbaker
requested changes
Apr 15, 2019
There was a problem hiding this comment.
Hi @JonGoSonobi
This overall looks good, but I did have a question on one part. Please see the comment below when you have the chance.
Thanks.
|
@JonGoSonobi Thanks for the update; LGTM |
jsnellbaker
approved these changes
Apr 19, 2019
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
…bid#3743) * Sonobi Adapter added support for UnifiedId/tdid * fixed unit test * added semi colons * removed fallback tdid on crumbs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Added Sonobi Adapter support for Unified/Tradedesk ID
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Updated Sonobi Docs to add userId support for unifiedId/tradedesk prebid.github.io#1258