Submit NAF Digital Bidder Adapter

[vyatsun]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

• test parameters for validating bids

{
  bidder: 'nafdigital',
  params: {
    publisherId: 2141020
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

• contact email of the adapter’s maintainer: vyatsun@gmail.com
• official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

• prebid/prebid.github.io#1262

Other information

[sumit116]

Hi,
Thanks for submitting your adaptor. I found some changes required in your adaptor files, mentioned in my comments. I tested your adaptor on hello-world page and find everything else working fine. Can you please make the necessary changes and let me know if you have any questions.

[sumit116]

While testing on hello_world page, I found that there is no response for request to 'https://nafdigitalbidder.com/hb'. Ideally it should return the bid object back as response like all other bid adaptors. Can you please check this at your end?

[vyatsun]

Hi @sumit116
Thanks for your response. Can you please provide the request payload as well as the country you're sending the request from, so that I can create a targeting for you on the server?

[sumit116]

Hi @sumit116
Thanks for your response. Can you please provide the request payload as well as the country you're sending the request from, so that I can create a targeting for you on the server?

[sumit116]

HI @vyatsun ,

Request Payload: {"id":"3f1fdfb0737e75","imp":[{"id":"2ce3666274b969","banner":{"format":[{"w":300,"h":250},{"w":300,"h":600}],"ext":{"viewability":100}},"tagid":"div-gpt-ad-1460505748561-0","bidfloor":0.01}],"site":{"domain":"test.localhost:9999","page":"http://test.localhost:9999/integrationExamples/gpt/hello_world.html?pbjs_debug=true","publisher":{"id":2141020}},"device":{"devicetype":2,"w":1366,"h":768},"tmax":3000}

Country: India

[vyatsun]

Thanks @sumit116
I've created a new targeting on the server. Could you try again? Hopefully it will work this time.

[sumit116]

Thanks @vyatsun, Yes its working now.

Tested the adaptor on hello_world page and all unit tests have passed. Test coverage of the adaptor is above 80%. The changes are working well against all parameters listed in https://github.com/prebid/Prebid.js/blob/master/PR_REVIEW.md, hence approving the PR.