fix handling of gdpr object #3756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumit116
approved these changes
Apr 19, 2019
There was a problem hiding this comment.
Hi,
I tested the changes on hello_world and gdpr_hello_world pages. Just one issue here that request to 'https://orbidder.otto.de/bid' gives me an 403 error, can you please check this at your end.
Rest of the things seem to be working fine. Thanks.
The gdprConsent object is now there in the request payload for 'https://orbidder.otto.de/bid', hence approving the changes.
|
The backend does some checks against the account id, so that's why you got the 403 error. I just double checked, things are running fine now. Do you need anything else for the changes to be merged? |
jaiminpanchal27
approved these changes
Apr 23, 2019
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
* initial orbidder version in personal github repo * use adUnits from orbidder_example.html * replace obsolete functions * forgot to commit the test * check if bidderRequest object is available * try to fix weird safari/ie issue * ebayK: add more params * update orbidderBidAdapter.md * use spec.<function> instead of this.<function> for consistency reasons * add bidfloor parameter to params object * fix gdpr object handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
gdrp data is erroneously retrieved from validBidRequest item instead of bidderRequest. This cannot work and has got to be fixed.