Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change external-uid to camelcase #3757

Merged
merged 1 commit into from
Apr 19, 2019
Merged

change external-uid to camelcase #3757

merged 1 commit into from
Apr 19, 2019

Conversation

sumit116
Copy link
Contributor

Type of change

  • Bugfix

Description of change

change external user id to camel-case from 'external_uid' to 'externalUid' since and object key cannot have underscore.

  • test parameters for validating bids
{
  bidder: 'apnexus',
  params: {
   user: {externalUid:'1234567890abcdefg',age:35,gender:1,language:'EN', segments:[1,2]}
  }
}

Tested the integration with adserver using the Hello World sample page.

Other information

Jira Link: https://jira.corp.appnexus.com/browse/RAD-2553

@sumit116 sumit116 changed the title change externalUid to camelcase change external-uid to camelcase Apr 17, 2019
@sumit116 sumit116 merged commit 3e97e59 into master Apr 19, 2019
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants