Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Native] Add privacyIcon for native add #3770

Merged
merged 1 commit into from
Apr 22, 2019
Merged

[Native] Add privacyIcon for native add #3770

merged 1 commit into from
Apr 22, 2019

Conversation

zhenyi2697
Copy link
Contributor

@zhenyi2697 zhenyi2697 commented Apr 19, 2019 •
edited
Loading

Privacy icon can be provided by some bidders, adding this field allows
publisher to render privacy link with provided icon on it

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Privacy icon can be provided by some bidders, adding this field allows
publisher to render privacy link with provided icon on it

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

@zhenyi2697
[Native] Add privacyIcon for native add
f4ce090 
Privacy icon can be provided by some bidders, adding this field allows
publisher to render privacy link with provided icon on it
@mike-chowla mike-chowla self-assigned this Apr 20, 2019
@mike-chowla mike-chowla self-requested a review April 20, 2019 00:09
mike-chowla
mike-chowla approved these changes Apr 20, 2019
View reviewed changes
Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-chowla mike-chowla added the needs 2nd review Core module updates require two approvals from the core team label Apr 20, 2019
@mike-chowla mike-chowla requested a review from jsnellbaker April 20, 2019 00:11
@jsnellbaker jsnellbaker self-assigned this Apr 22, 2019
@jsnellbaker jsnellbaker merged commit 71d5753 into prebid:master Apr 22, 2019
@zhenyi2697 zhenyi2697 deleted the feature/add-privacy-icon-for-native-ad branch April 26, 2019 15:03
jacekburys-quantcast pushed a commit to jacekburys-quantcast/Prebid.js that referenced this pull request May 15, 2019
@zhenyi2697 @jacekburys-quantcast
[Native] Add privacyIcon for native ad (prebid#3770)
6383422 
Privacy icon can be provided by some bidders, adding this field allows
publisher to render privacy link with provided icon on it
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
@zhenyi2697
[Native] Add privacyIcon for native ad (prebid#3770)
827ad2a 
Privacy icon can be provided by some bidders, adding this field allows
publisher to render privacy link with provided icon on it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnellbaker jsnellbaker jsnellbaker approved these changes

@mike-chowla mike-chowla mike-chowla approved these changes

Assignees

@mike-chowla mike-chowla

@jsnellbaker jsnellbaker

Labels
needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhenyi2697 @mike-chowla @jsnellbaker