-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgid adapter: native support, minor changes #3774
Conversation
This pull request introduces 1 alert when merging a24a528 into 253cbf4 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
Hello, @mkendall07, please revise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Thanks for submitting your adaptor. I tested your adaptor on a demo page and found that functionality is working well and I am getting valid response for my request. But I also found that test coverage of the adaptor is below 80% (its 74.44% ). Can you please add missing test cases. Please Let me know if you have any questions.
Hi @sumit116, please review the last commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the changes on hello_world page and all unit tests have passed. Test coverage of the adaptor is above 80%. The changes are working well against all parameters listed in https://github.com/prebid/Prebid.js/blob/master/PR_REVIEW.md, hence approving the PR.
Thanx @sumit116, could you please remove "needs unit tests" label |
* native support & minor changes * native support & minor changes * increase test coverage * fix win price value * fix win price value tests * fix alias, fix bidfloor * remove alias
* native support & minor changes * native support & minor changes * increase test coverage * fix win price value * fix win price value tests * fix alias, fix bidfloor * remove alias
Type of change
Description of change
native support added, added currency and bidfloor optional parameters
Be sure to test the integration with your adserver using the Hello World sample page.
contact email of the adapter’s maintainer
prebid@mgid.com
official adapter submission
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
native support & some optional params added prebid.github.io#1283
Other information