Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgid adapter: native support, minor changes #3774

Merged
merged 9 commits into from
May 14, 2019
Merged

mgid adapter: native support, minor changes #3774

merged 9 commits into from
May 14, 2019

Conversation

Gaudeamus
Copy link
Contributor

@Gaudeamus Gaudeamus commented Apr 23, 2019

Type of change

  • Feature
  • Refactoring (no functional changes, no api changes)

Description of change

native support added, added currency and bidfloor optional parameters

  • test parameters for validating bids
var adUnits = [{
  code: 'div-prebid',
  mediaTypes: {
    native: {
        image: {
            sendId: true,
            required: true,
            sizes: [80, 80]
        },
        clickUrl: {
            sendId: true,
            required: false
        },
        title: {
            required: true,
            len: 80
        },
        sponsored: {
            required: false
        }
    }
  },
  // Replace this object to test a new Adapter!
  bids: [{
    bidder: 'mgid',
    params : {
        accountId : "233", //test accountId, please replace after test
        placementId : "350971" // 300x250 test placementId, please replace after test
    }
  }]
}];

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
    prebid@mgid.com

  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@mkendall07
Copy link
Member

This pull request introduces 1 alert when merging a24a528 into 253cbf4 - view on LGTM.com

new alerts:

  • 1 for Unneeded defensive code

Comment posted by LGTM.com

@Gaudeamus
Copy link
Contributor Author

Hello, @mkendall07, please revise

@bretg bretg changed the title native support, minor changes mgid adapter: native support, minor changes May 1, 2019
@bretg bretg requested a review from sumit116 May 1, 2019 13:29
Copy link
Contributor

@sumit116 sumit116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Thanks for submitting your adaptor. I tested your adaptor on a demo page and found that functionality is working well and I am getting valid response for my request. But I also found that test coverage of the adaptor is below 80% (its 74.44% ). Can you please add missing test cases. Please Let me know if you have any questions.

@Gaudeamus
Copy link
Contributor Author

Hi @sumit116, please review the last commit

Copy link
Contributor

@sumit116 sumit116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes on hello_world page and all unit tests have passed. Test coverage of the adaptor is above 80%. The changes are working well against all parameters listed in https://github.com/prebid/Prebid.js/blob/master/PR_REVIEW.md, hence approving the PR.

@sumit116 sumit116 added the LGTM label May 7, 2019
@Gaudeamus
Copy link
Contributor Author

Thanx @sumit116, could you please remove "needs unit tests" label

@jaiminpanchal27 jaiminpanchal27 merged commit 9166db8 into prebid:master May 14, 2019
jacekburys-quantcast pushed a commit to jacekburys-quantcast/Prebid.js that referenced this pull request May 15, 2019
* native support & minor changes

* native support & minor changes

* increase test coverage

* fix win price value

* fix win price value tests

* fix alias, fix bidfloor

* remove alias
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
* native support & minor changes

* native support & minor changes

* increase test coverage

* fix win price value

* fix win price value tests

* fix alias, fix bidfloor

* remove alias
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants