Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VIS.X bid adapter #3777

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Update VIS.X bid adapter #3777

merged 1 commit into from
Apr 25, 2019

Conversation

mk0x9
Copy link
Contributor

@mk0x9 mk0x9 commented Apr 24, 2019

Type of change

  • Bugfix

Description of change

Sometimes publishers use the same SSP ad unit ID for several 'physical' ad slots. So we allowed duplicated AUs in requests. Also now we will check that one response from SSP would not be duplicated on in the adapter.

* update VIS.X bid adapter to support identical uids in the parameters
* added wrapperType and wrapperVersion parameters in the ad request for VIS.X bid adapter
* added second iteration of the response processing to ignore requested sizes in VIS.X bid adapter
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker merged commit f1aeb85 into prebid:master Apr 25, 2019
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
* update VIS.X bid adapter to support identical uids in the parameters
* added wrapperType and wrapperVersion parameters in the ad request for VIS.X bid adapter
* added second iteration of the response processing to ignore requested sizes in VIS.X bid adapter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants